Re: [HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Craig Ringer
On 30 August 2016 at 00:37, Robert Haas wrote: > Long story short, I kind of agree that it might have been better to > expose server_version_num rather than server_version in the beginning, > but I'm not sure that it really helps anybody now, especially given > our

Re: [HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Craig Ringer
On 30 Aug 2016 9:07 AM, "Dave Cramer" wrote: > > > On 29 August 2016 at 15:42, Tom Lane wrote: >> >> Kevin Grittner writes: >> > Regarding Java, for anything above the driver itself the >> > JDBC API says the DatabaseMetaData class must

Re: [HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Dave Cramer
On 29 August 2016 at 15:42, Tom Lane wrote: > Kevin Grittner writes: > > Regarding Java, for anything above the driver itself the > > JDBC API says the DatabaseMetaData class must implement these > > methods: > > ... > > That *should* make it just a

Re: [HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Tom Lane
Kevin Grittner writes: > Regarding Java, for anything above the driver itself the > JDBC API says the DatabaseMetaData class must implement these > methods: > ... > That *should* make it just a problem for the driver itself. That > seems simple enough until you check what

Re: [HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Kevin Grittner
On Mon, Aug 29, 2016 at 11:37 AM, Robert Haas wrote: > Note that these are all one-liners, and I bet the same is true in > mostly other languages. Even in notoriously verbose languages like > Java or Cobol or ADA it can't be very hard. Regarding Java, for anything above

Re: [HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Magnus Hagander
On Mon, Aug 29, 2016 at 6:37 PM, Robert Haas wrote: > On Mon, Aug 29, 2016 at 7:12 PM, Tom Lane wrote: > > Craig Ringer writes: > >> The same sort of problems apply to network clients, but network > >> clients don't currently

Re: [HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Robert Haas
On Mon, Aug 29, 2016 at 7:12 PM, Tom Lane wrote: > Craig Ringer writes: >> The same sort of problems apply to network clients, but network >> clients don't currently get that option because we only send >> server_version on the wire in the startup

Re: [HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Tom Lane
Craig Ringer writes: > The same sort of problems apply to network clients, but network > clients don't currently get that option because we only send > server_version on the wire in the startup packet. We don't send > server_version_num. > It'll be immediately useful to

[HACKERS] [PATCH] Send numeric version to clients

2016-08-29 Thread Craig Ringer
Hi all It's recently been observed[1] that the 10.0 version scheme change has affected PostGIS, which relies on parsing the server version string and broke when faced with a string like "10.0devel" since it expected a minor version. In that thread Tom points out [2] that they should be using