Fabien COELHO escribió:
> For the text formatting, I tried to keep the screen width under 80
> characters, because if the line is too wide it is harder to read as
> the eye may loose the alignment. But being homogeneous with other
> commands is fine with me as well.
The format chosen by Robert fi
[...] So I changed that, and committed this, with some further cosmetic
changes. [...]
Thanks for the commit & the style improvements.
For the text formatting, I tried to keep the screen width under 80
characters, because if the line is too wide it is harder to read as the
eye may loose the
On Thu, Jun 27, 2013 at 10:24 AM, Fujii Masao wrote:
> On Thu, Jun 27, 2013 at 10:02 PM, Robert Haas wrote:
>> On Tue, Jun 25, 2013 at 3:09 PM, Fabien COELHO wrote:
I think --quiet-log should be spelled --quiet.
>>>
>>> ISTM that --quiet usually means "not verbose on stdout", so I added log
On Thu, Jun 27, 2013 at 10:02 PM, Robert Haas wrote:
> On Tue, Jun 25, 2013 at 3:09 PM, Fabien COELHO wrote:
>>> I think --quiet-log should be spelled --quiet.
>>
>> ISTM that --quiet usually means "not verbose on stdout", so I added log
>> because this was specific to the log output, and that th
On Tue, Jun 25, 2013 at 3:09 PM, Fabien COELHO wrote:
>> I think --quiet-log should be spelled --quiet.
>
> ISTM that --quiet usually means "not verbose on stdout", so I added log
> because this was specific to the log output, and that there may be a need
> for a --quiet option for stdout at some
I think I'd like to quibble with some of the names a bit, though.
That is a good idea, because I'm not a native English speaker and I was
not so sure for many options.
The patch adds --fill-factor, but I think we should spell it
without the hyphen: --fillfactor.
Fine with me.
I think -
On Tue, Jun 25, 2013 at 12:17 PM, Tom Lane wrote:
> Robert Haas writes:
>> I would like to solicit opinions on whether this is a good idea. I
>> understand that the patch author thinks it's a good idea, and I don't
>> have a strong position either way. But I want to hear what other
>> people th
Robert Haas writes:
> I would like to solicit opinions on whether this is a good idea. I
> understand that the patch author thinks it's a good idea, and I don't
> have a strong position either way. But I want to hear what other
> people think.
If it makes pgbench more consistent with psql's com
Robert Haas escribió:
> On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello
> wrote:
> > On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO wrote:
> >>> Please fix that and re-send the patch.
> >> Find attached diff wrt current master.
> > Thanks.
>
> I would like to solicit opinions on whether
On 2013-06-25 12:11:06 -0400, Robert Haas wrote:
> On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello
> wrote:
> > On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO wrote:
> >>> Please fix that and re-send the patch.
> >> Find attached diff wrt current master.
> > Thanks.
>
> I would like to
On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello
wrote:
> On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO wrote:
>>> Please fix that and re-send the patch.
>> Find attached diff wrt current master.
> Thanks.
I would like to solicit opinions on whether this is a good idea. I
understand th
On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO wrote:
>
> Please fix that and re-send the patch.
>>
>
> Find attached diff wrt current master.
>
>
Thanks.
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://
Please fix that and re-send the patch.
Find attached diff wrt current master.
--
Fabien.diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
index 1303217..f39fed3 100644
--- a/contrib/pgbench/pgbench.c
+++ b/contrib/pgbench/pgbench.c
@@ -2109,6 +2109,30 @@ int
main(int argc, c
> New submission which put long options in alphabetical order, which seems
> more logical.
>
> This is for reference to the next commitfest.
When I applied your patch appeared the following messages:
$ patch -p1 < /tmp/pgbench-longopts.patch
patching file contrib/pgbench/pgbench.c
Hunk #1 succe
New submission which put long options in alphabetical order, which seems
more logical.
This is for reference to the next commitfest.
--
Fabien.diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
index 24dab1f..ba36e66 100644
--- a/contrib/pgbench/pgbench.c
+++ b/contrib/pgbench
Hello Robert,
This very minor patch adds a corresponding long option to all short
(one letter) options of pgbench. [...]
I don't really have an opinion on whether this is worth doing, but we'd
probably want to update all of our client utilities, not just pgbench,
if we did.
The current st
On Thu, May 2, 2013 at 1:59 PM, Fabien COELHO wrote:
> This is mostly for reference to the next commitfest.
>
> This very minor patch adds a corresponding long option to all short (one
> letter) options of pgbench. In particular for connection options there is
> now --host --username --port option
This is mostly for reference to the next commitfest.
This very minor patch adds a corresponding long option to all short (one
letter) options of pgbench. In particular for connection options there is
now --host --username --port options similar to the "psql" client.
While I was at developing
18 matches
Mail list logo
