Re: [HACKERS] [PATCHES] Double Backslash example patch

2003-12-17 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: BTW, what happened to the $QUOTE$ quoting idea? Was it applied, or even developed? I'd like to see it done for 7.5, but haven't personally had time to go further than the proof-of-concept backend patch I posted awhile ago. I think the minimum amount of

Re: [HACKERS] [PATCHES] Double Backslash example patch

2003-12-17 Thread Andreas Pflug
Tom Lane wrote: I think the minimum amount of additional work that has to be done before we can apply it is to teach psql's input parser about $QUOTE$ --- without that, the feature is not only useless but counterproductive. IMHO it's not useless. pgAdmin already knows that quoting scheme...

Re: [HACKERS] [PATCHES] Double Backslash example patch

2003-12-17 Thread Andrew Dunstan
Andreas Pflug wrote: Tom Lane wrote: I think the minimum amount of additional work that has to be done before we can apply it is to teach psql's input parser about $QUOTE$ --- without that, the feature is not only useless but counterproductive. IMHO it's not useless. pgAdmin already knows

Re: [HACKERS] [PATCHES] Double Backslash example patch

2003-12-17 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: I see that psql/mainloop.c contains this comment: * FIXME: rewrite this whole thing with flex Is now the time to do that? If you feel like giving it a shot, ain't nobody gonna stand in your way. MainLoop() is well past the level of unmaintainability

Re: [HACKERS] [PATCHES] Double Backslash example patch

2003-12-17 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: I see that psql/mainloop.c contains this comment: * FIXME: rewrite this whole thing with flex Is now the time to do that? If you feel like giving it a shot, ain't nobody gonna stand in your way. MainLoop() is well past the level of

Re: [HACKERS] [PATCHES] Double Backslash example patch

2003-12-16 Thread Alvaro Herrera
On Tue, Dec 16, 2003 at 11:17:11AM -0800, David Fetter wrote: [Moved to hackers -- this belongs to -docs anyway, doesn't it?] With all due respect, Peter, it is only implicit in the docs, and that is not always good enough. An explicit example will help, as PostgreSQL's quoting system would

Re: [HACKERS] [PATCHES] Double Backslash example patch

2003-12-16 Thread Jon Jensen
On Tue, 16 Dec 2003, Alvaro Herrera wrote: BTW, what happened to the $QUOTE$ quoting idea? Was it applied, or even developed? I believe it's still on the to-do list, but was pushed off until 7.5 or whenever it gets done. Jon ---(end of

Re: [HACKERS] [PATCHES] Double Backslash example patch

2003-12-16 Thread Bruce Momjian
Alvaro Herrera wrote: On Tue, Dec 16, 2003 at 11:17:11AM -0800, David Fetter wrote: [Moved to hackers -- this belongs to -docs anyway, doesn't it?] With all due respect, Peter, it is only implicit in the docs, and that is not always good enough. An explicit example will help, as