Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-12-23 Thread Michael Paquier
On Wed, Jul 9, 2014 at 9:53 PM, MauMau wrote: > But the source tree contains as many as 206 Makefiles. I'm worried that it > will waste the install time. Should all these Makefiles be examined, or 16 > Makefiles in src/interfaces/? Not really. IMO the best solution is to extract the path of the

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-09-15 Thread Heikki Linnakangas
This patch has been sitting in the commitfest with no activity since this email from July. What's the real status, who's got the ball on this one? Please update the commitfest app accordingly. If nothing happens in the next few days, I'll mark this as Returned with Feedback. On 07/09/2014 03:5

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-07-09 Thread MauMau
From: "Alvaro Herrera" I think the suggestion by Peter Eisentraut upthread was pretty reasonable -- the Makefiles are already aware that they are building a shared library, so scrape the info off them. The less hardcoded stuff in the msvc framework, the better. I overlooked his mail. Do you

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-07-08 Thread Alvaro Herrera
Asif Naeem wrote: > Yes. Can you please take a look at Win_lib_bin.patch I shared earlier ?, I > think it is or similar approach will be appropriate. Thanks. I think the suggestion by Peter Eisentraut upthread was pretty reasonable -- the Makefiles are already aware that they are building a shared

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-07-08 Thread Asif Naeem
Yes. Can you please take a look at Win_lib_bin.patch I shared earlier ?, I think it is or similar approach will be appropriate. Thanks. Regards, Muhammad Asif Naeem On Tue, Jul 8, 2014 at 5:53 PM, MauMau wrote: > From: "Asif Naeem" > > Other than my pervious comments, patch looks good to me.

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-07-08 Thread MauMau
From: "Asif Naeem" Other than my pervious comments, patch looks good to me. Thanks. Thanks for reviewing. I understood that your previous comment was to suggest copying the desired DLLs directly from Release/Debug folder to bin. But I'm afraid it cannot be done cleanly... CopySolutionOutpu

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-07-07 Thread Asif Naeem
Hi MauMau, Other than my pervious comments, patch looks good to me. Thanks. Regards, Muhammad Asif Naeem On Wed, Feb 26, 2014 at 2:14 AM, Peter Eisentraut wrote: > You should be able to do this without specifically referencing the names > "libpq" or "ecpg". Look into the Makefile, if it defi

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-02-25 Thread Peter Eisentraut
You should be able to do this without specifically referencing the names "libpq" or "ecpg". Look into the Makefile, if it defines SO_MAJOR_VERSION, then it's a library you are concerned with, and then do the copying or moving. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2014-01-31 Thread Asif Naeem
Hi MauMau, I have't completed tested all the expects of submitted patch yet. I would like to share my findings so far. By looking at the patch I do feel that there is room for improvement in the patch, Instead of moving related dll's from lib directory to bin directory later in the installation pr

Re: [HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2013-12-04 Thread MauMau
From: "MauMau" In addition, I'll remove libpq.dll from lib folder unless somebody objects. Currently, libpq.dll is placed in both bin and lib. I guess libpq.dll was left in lib because it was considered necessary for ECPG DLLs. The attached patch also removes libpq.dll from lib folder. I do

[HACKERS] [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder

2013-12-03 Thread MauMau
Hello, The attached patch implements the below proposal, and moves libecpg.dll, libecpg_compat.dll, and libpgtypes.dll from lib to bin folder on Windows, where they should be. http://www.postgresql.org/message-id/10470B394DB8486F93AC60107CC44C8B@maumau As Andrew-san said, I don't expect it t