Re: [HACKERS] -f output file option for pg_dumpall

2007-01-22 Thread elein
On Mon, Jan 15, 2007 at 10:13:16AM -0500, Andrew Dunstan wrote: Neil Conway wrote: On Thu, 2007-01-11 at 14:36 -0500, Neil Conway wrote: I don't think they need to be integrated any time soon, but if we were to design pg_dump and pg_dumpall from scratch, it seems more logical to use a

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-22 Thread Andrew Dunstan
elein wrote: On Mon, Jan 15, 2007 at 10:13:16AM -0500, Andrew Dunstan wrote: Neil Conway wrote: On Thu, 2007-01-11 at 14:36 -0500, Neil Conway wrote: I don't think they need to be integrated any time soon, but if we were to design pg_dump and pg_dumpall from scratch, it seems more logical

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-15 Thread Andrew Dunstan
Neil Conway wrote: On Thu, 2007-01-11 at 14:36 -0500, Neil Conway wrote: I don't think they need to be integrated any time soon, but if we were to design pg_dump and pg_dumpall from scratch, it seems more logical to use a single program On thinking about this some more, it might be

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-14 Thread Neil Conway
On Thu, 2007-01-11 at 14:36 -0500, Neil Conway wrote: I don't think they need to be integrated any time soon, but if we were to design pg_dump and pg_dumpall from scratch, it seems more logical to use a single program On thinking about this some more, it might be useful to factor much of

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-11 Thread Dave Page
Possibly, to merge the two programs. I'm intending to put some time into the append and seperating globals items, but I don't think I have the time to merge the apps given Tom's concerns and some further investigation. Regards, Dave. Bruce Momjian wrote: Is there a TODO here?

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-11 Thread Bruce Momjian
Dave Page wrote: Possibly, to merge the two programs. I'm intending to put some time into the append and seperating globals items, but I don't think I have the time to merge the apps given Tom's concerns and some further investigation. Yes, I was just wondering if an append mode for Win32

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-11 Thread Neil Conway
On Fri, 2007-01-05 at 17:52 -0500, Tom Lane wrote: I think this will be an exercise in time-wasting, and very possibly destabilize *both* tools. pg_dump has never been designed to reconnect to a different database; for instance there isn't any code for resetting all the internal state that it

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-09 Thread Dave Page
Andreas Pflug wrote: Not much function to re-create here, single exception is extracting cluster wide data, the -g option, that's why I mentioned scripting. But apparently this didn't get into pgadmin svn any more, so I need to retract this proposal. Eh? Your SCRIPT code is still there - or

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-09 Thread Andreas Pflug
Dave Page wrote: Andreas Pflug wrote: Not much function to re-create here, single exception is extracting cluster wide data, the -g option, that's why I mentioned scripting. But apparently this didn't get into pgadmin svn any more, so I need to retract this proposal. Eh? Your

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-08 Thread Dave Page
Dave Page wrote: I don't object to it in principle, but I think a bit more thought is needed as to what's the goal. A stupid append option would be enough for pg_dumpall's current capabilities (ie, text output only) --- but is it reasonable to consider generalizing -Fc and -Ft modes to deal

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-08 Thread Jim C. Nasby
On Fri, Jan 05, 2007 at 08:05:26PM +, Dave Page wrote: Andreas Pflug wrote: Dave Page wrote: In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-08 Thread Andreas Pflug
Jim C. Nasby wrote: It might make sense to provide a programmatic interface to pg_dump to provide tools like pgAdmin more flexibility. Are you talking about pg_dump in a lib? Certainly a good idea, because it allows better integration (e.g. progress bar). But it certainly doesn't make sense

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-06 Thread Dave Page
--- Original Message --- From: Tom Lane [EMAIL PROTECTED] To: Dave Page [EMAIL PROTECTED] Sent: 1/5/07, 10:48:17 PM Subject: Re: [HACKERS] -f output file option for pg_dumpall Wouldn't it be easier/better to re-point stdout at the -f file, and not touch pg_dump at all? First

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-06 Thread Dave Page
--- Original Message --- From: Tom Lane [EMAIL PROTECTED] To: Dave Page [EMAIL PROTECTED] Sent: 1/5/07, 10:52:37 PM Subject: Re: [HACKERS] -f output file option for pg_dumpall I think this will be an exercise in time-wasting, and very possibly destabilize *both* tools. pg_dump

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-06 Thread Peter Eisentraut
Dave Page wrote: In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of entire clusters as well as role and tablespace definitions, we need to be able to get

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-06 Thread Tom Lane
Dave Page [EMAIL PROTECTED] writes: From: Tom Lane [EMAIL PROTECTED] I think forking a separate pg_dump for each database is a perfectly fine arrangement, and should be left alone. Hmm, would you be happy with my original proposal to add an append option to pg_dump? I don't object to it

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-06 Thread Dave Page
Peter Eisentraut wrote: Dave Page wrote: In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of entire clusters as well as role and tablespace definitions, we

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-06 Thread Dave Page
Tom Lane wrote: Dave Page [EMAIL PROTECTED] writes: From: Tom Lane [EMAIL PROTECTED] I think forking a separate pg_dump for each database is a perfectly fine arrangement, and should be left alone. Hmm, would you be happy with my original proposal to add an append option to pg_dump? I

[HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Dave Page
In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of entire clusters as well as role and tablespace definitions, we need to be able to get pg_dumpall to write

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Joshua D. Drake
As far as I can see, adding a -f option to pg_dumpall should be straight forward, the only issue being that we'd need to pass pg_dump an additional (undocumented?) option to tell it to append to the output file instead of writing it as normal. Any thoughts or better ideas? Yeah :) Getting

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Andrew Dunstan
Dave Page wrote: In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of entire clusters as well as role and tablespace definitions, we need to be able to get

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Darcy Buskermolen
On Friday 05 January 2007 09:40, Andrew Dunstan wrote: Dave Page wrote: In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of entire clusters as well

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread David Fetter
On Fri, Jan 05, 2007 at 12:40:20PM -0500, Andrew Dunstan wrote: Dave Page wrote: In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of entire clusters as

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Dave Page
David Fetter wrote: This seems a bit like piecemeal reform. Here are some things I'd like to see that affect this area: . merge pg_dump and pg_dumpall (e.g. add a flag to pg_dump that says do the lot) . multi-db non-text dumps And while we're about it, can we teach pg_restore to handle text

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Dave Page
Andreas Pflug wrote: Dave Page wrote: In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of entire clusters as well as role and tablespace definitions, we

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Tom Lane
Dave Page [EMAIL PROTECTED] writes: As far as I can see, adding a -f option to pg_dumpall should be straight forward, the only issue being that we'd need to pass pg_dump an additional (undocumented?) option to tell it to append to the output file instead of writing it as normal. Wouldn't it

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Tom Lane
Dave Page [EMAIL PROTECTED] writes: Hmm, well I have no interest in the latter at present, but assuming the powers that be will allow me some time to do so, I will look at merging pg_dump and pg_dumpall as that seems to be the way people want to go. I think this will be an exercise in

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Tino Wildenhain
Tom Lane schrieb: Dave Page [EMAIL PROTECTED] writes: As far as I can see, adding a -f option to pg_dumpall should be straight forward, the only issue being that we'd need to pass pg_dump an additional (undocumented?) option to tell it to append to the output file instead of writing it as

Re: [HACKERS] -f output file option for pg_dumpall

2007-01-05 Thread Andreas Pflug
Dave Page wrote: In pgAdmin we use pg_dump's -f option to write backup files. The IO streams are redirected to display status and errors etc. in the GUI. In order to enhance the interface to allow backup of entire clusters as well as role and tablespace definitions, we need to be able to get