Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-06-05 Thread Peter Eisentraut
On 6/2/17 22:13, Peter Eisentraut wrote: > On 5/27/17 06:54, Petr Jelinek wrote: >> On 27/05/17 04:00, Euler Taveira wrote: >>> 2017-05-26 21:29 GMT-03:00 Petr Jelinek >> >: >>> >>> >>> Actually another possibility would be to remove the REFRESH keyword >>>

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-06-02 Thread Peter Eisentraut
On 5/27/17 06:54, Petr Jelinek wrote: > On 27/05/17 04:00, Euler Taveira wrote: >> 2017-05-26 21:29 GMT-03:00 Petr Jelinek > >: >> >> >> Actually another possibility would be to remove the REFRESH keyword >> completely and just have [ WITH (...) ] and ha

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-27 Thread Petr Jelinek
On 27/05/17 04:00, Euler Taveira wrote: > 2017-05-26 21:29 GMT-03:00 Petr Jelinek >: > > > Actually another possibility would be to remove the REFRESH keyword > completely and just have [ WITH (...) ] and have the refresh option > there, ie simpli

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-26 Thread Euler Taveira
2017-05-26 21:29 GMT-03:00 Petr Jelinek : > > Actually another possibility would be to remove the REFRESH keyword > completely and just have [ WITH (...) ] and have the refresh option > there, ie simplified version of what you have suggested (without the > ugliness of specifying refresh twice to d

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-26 Thread Petr Jelinek
On 27/05/17 02:13, Euler Taveira wrote: > 2017-05-26 17:58 GMT-03:00 Peter Eisentraut > >: > > On 5/24/17 15:38, Petr Jelinek wrote: > >>> I wonder if we actually need the SKIP REFRESH syntax, there is the > >>> "REFRESH [ WITH ... ]" when user

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-26 Thread Euler Taveira
2017-05-26 17:58 GMT-03:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > On 5/24/17 15:38, Petr Jelinek wrote: > >>> I wonder if we actually need the SKIP REFRESH syntax, there is the > >>> "REFRESH [ WITH ... ]" when user wants to refresh, so if REFRESH is not > >>> specified, we can ju

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-26 Thread Peter Eisentraut
On 5/24/17 15:38, Petr Jelinek wrote: >>> I wonder if we actually need the SKIP REFRESH syntax, there is the >>> "REFRESH [ WITH ... ]" when user wants to refresh, so if REFRESH is not >>> specified, we can just behave as if SKIP REFRESH was used, it's not like >>> there is 3rd possible behavior. >

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-24 Thread Petr Jelinek
On 24/05/17 21:28, Petr Jelinek wrote: > On 24/05/17 21:21, Petr Jelinek wrote: >> On 24/05/17 21:07, Euler Taveira wrote: >>> 2017-05-23 6:00 GMT-03:00 tushar >> >: >>> >>> >>> s=# alter subscription s1 set publication skip refresh ; >>> NOTICE: remo

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-24 Thread Petr Jelinek
On 24/05/17 21:21, Petr Jelinek wrote: > On 24/05/17 21:07, Euler Taveira wrote: >> 2017-05-23 6:00 GMT-03:00 tushar > >: >> >> >> s=# alter subscription s1 set publication skip refresh ; >> NOTICE: removed subscription for table public.t >> NOTIC

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-24 Thread Petr Jelinek
On 24/05/17 21:07, Euler Taveira wrote: > 2017-05-23 6:00 GMT-03:00 tushar >: > > > s=# alter subscription s1 set publication skip refresh ; > NOTICE: removed subscription for table public.t > NOTICE: removed subscription for table public.t1 >

Re: [HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-24 Thread Euler Taveira
2017-05-23 6:00 GMT-03:00 tushar : > > s=# alter subscription s1 set publication skip refresh ; > NOTICE: removed subscription for table public.t > NOTICE: removed subscription for table public.t1 > ALTER SUBSCRIPTION > s=# That's a design flaw. Since SKIP is not a reserved word, parser consi

[HACKERS] ALTER SUBSCRIPTION ..SET PUBLICATION refresh is not throwing error.

2017-05-23 Thread tushar
Hi, ALTER SUBSCRIPTION ..SET PUBLICATION refresh is removing all the attached subscription('s). X Machine - s=# create table t(n int); CREATE TABLE s=# create table t1(n int); CREATE TABLE s=# create publication pub for table t,t1; CREATE PUBLICATION s=# Y Machine - s=# create table t(n