On Mon, Jan 27, 2014 at 12:49 PM, Fujii Masao wrote:
> On Mon, Jan 27, 2014 at 11:53 AM, Michael Paquier
> wrote:
>> On Mon, Jan 27, 2014 at 11:29 AM, Michael Paquier
>> wrote:
>>> Hi,
>>>
>>> Please find attached an updated patch (context diffs) improving the
>>> comments related to ALTER SYSTE
On Mon, Jan 27, 2014 at 11:53 AM, Michael Paquier
wrote:
> On Mon, Jan 27, 2014 at 11:29 AM, Michael Paquier
> wrote:
>> Hi,
>>
>> Please find attached an updated patch (context diffs) improving the
>> comments related to ALTER SYSTEM. This patch does nothing for the
>> suffix tmp/temp used in a
On Mon, Jan 27, 2014 at 11:29 AM, Michael Paquier
wrote:
> Hi,
>
> Please find attached an updated patch (context diffs) improving the
> comments related to ALTER SYSTEM. This patch does nothing for the
> suffix tmp/temp used in a couple of places of the code, it only
> corrects some typos and mak
Hi,
Please find attached an updated patch (context diffs) improving the
comments related to ALTER SYSTEM. This patch does nothing for the
suffix tmp/temp used in a couple of places of the code, it only
corrects some typos and makes the comments more consistent with
current code.
The inconsistenci
On Tue, Jan 21, 2014 at 7:02 PM, Michael Paquier
wrote:
> On Wed, Jan 22, 2014 at 5:29 AM, Alvaro Herrera
> wrote:
>> I agree with Michael that having pg_basebackup be aware of the ".temp"
>> suffix is ugly; for instance if we were to fix it to ".tmp" in ALTER
>> SYSTEM but forgot to change pg_ba
On Wed, Jan 22, 2014 at 1:15 AM, Robert Haas wrote:
> On Tue, Jan 21, 2014 at 7:47 AM, Michael Paquier
> wrote:
After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I
noticed a couple of typo mistakes as well as (I think) a weird way of
using the temporary auto-config
On Wed, Jan 22, 2014 at 5:29 AM, Alvaro Herrera
wrote:
> I agree with Michael that having pg_basebackup be aware of the ".temp"
> suffix is ugly; for instance if we were to fix it to ".tmp" in ALTER
> SYSTEM but forgot to change pg_basebackup, the check would be
> immediately broken. But on the o
Robert Haas escribió:
> I don't think there's any real reason to defined
> PG_AUTOCONF_FILENAME_TEMP. pg_stat_statements just writes
> PGSS_DUMP_FILE ".tmp" and that hasn't been a problem that I know of.
> I do wonder why ALTER SYSTEM SET is spelling the suffix "temp" instead
> of "tmp".
I agree
On Tue, Jan 21, 2014 at 7:47 AM, Michael Paquier
wrote:
>>> After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I
>>> noticed a couple of typo mistakes as well as (I think) a weird way of
>>> using the temporary auto-configuration name postgresql.auto.conf.temp
>>> in two different
On Mon, Jan 20, 2014 at 2:12 PM, Amit Kapila wrote:
> On Sat, Jan 18, 2014 at 7:59 PM, Michael Paquier
> wrote:
>> Hi all,
>>
>> After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I
>> noticed a couple of typo mistakes as well as (I think) a weird way of
>> using the temporary aut
On Sat, Jan 18, 2014 at 7:59 PM, Michael Paquier
wrote:
> Hi all,
>
> After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I
> noticed a couple of typo mistakes as well as (I think) a weird way of
> using the temporary auto-configuration name postgresql.auto.conf.temp
> in two differ
Hi all,
After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I
noticed a couple of typo mistakes as well as (I think) a weird way of
using the temporary auto-configuration name postgresql.auto.conf.temp
in two different places, resulting in the patch attached.
It might be an overkil
12 matches
Mail list logo
