Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-02 Thread Andres Freund
On 2016-03-01 18:31:42 +0100, Petr Jelinek wrote: > On 01/03/16 18:18, Andres Freund wrote: > >I'd rather just initialize commit_time to parsed->xact_time. > > > >This indeed is clearly a bug. I do wonder if anybody has a good idea > >about how to add regression tests for this? It's rather annoying

Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-01 Thread Petr Jelinek
On 01/03/16 18:18, Andres Freund wrote: Hi, On 2016-03-01 18:09:28 +0100, Petr Jelinek wrote: On 01/03/16 17:57, Alvaro Herrera wrote: Artur Zakirov wrote: Hello, Andres You have introduced a large replication progress tracking infrastructure last year. And there is a problem described at

Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-01 Thread Alvaro Herrera
Andres Freund wrote: > I'd rather just initialize commit_time to parsed->xact_time. That also works. Probably also change its declaration to actually be TimestampTz ... > This indeed is clearly a bug. I do wonder if anybody has a good idea > about how to add regression tests for this? It's rath

Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-01 Thread Andres Freund
Hi, On 2016-03-01 18:09:28 +0100, Petr Jelinek wrote: > On 01/03/16 17:57, Alvaro Herrera wrote: > >Artur Zakirov wrote: > >>Hello, Andres > >> > >>You have introduced a large replication progress tracking infrastructure > >>last year. And there is a problem described at the link in the quote belo

Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-01 Thread Alvaro Herrera
Petr Jelinek wrote: > On 01/03/16 17:57, Alvaro Herrera wrote: > >Artur Zakirov wrote: > >>Hello, Andres > >> > >>You have introduced a large replication progress tracking infrastructure > >>last year. And there is a problem described at the link in the quote below. > >> > >>Attached patch fix this

Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-01 Thread Petr Jelinek
On 01/03/16 17:57, Alvaro Herrera wrote: Artur Zakirov wrote: Hello, Andres You have introduced a large replication progress tracking infrastructure last year. And there is a problem described at the link in the quote below. Attached patch fix this issue. Is this patch correct? I will be grate

Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-01 Thread Alvaro Herrera
Artur Zakirov wrote: > Hello, Andres > > You have introduced a large replication progress tracking infrastructure > last year. And there is a problem described at the link in the quote below. > > Attached patch fix this issue. Is this patch correct? I will be grateful if > it is and if it will be

Re: [HACKERS] Confusing with commit time usage in logical decoding

2016-03-01 Thread Artur Zakirov
Hello, Andres You have introduced a large replication progress tracking infrastructure last year. And there is a problem described at the link in the quote below. Attached patch fix this issue. Is this patch correct? I will be grateful if it is and if it will be committed. Thanks. On 29.02

[HACKERS] Confusing with commit time usage in logical decoding

2016-02-29 Thread Artur Zakirov
Hello, I read this message http://www.postgresql.org/message-id/56d4197e.9050...@informatik.uni-kl.de Is this a bug or a typo? In DecodeCommit() in decode.c instead of: if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN) { origin_lsn = parsed->origin_lsn; commit_time = parsed->origin_t