Re: [HACKERS] Deprecating non-select rules (was Re: Last gasp)

2012-04-10 Thread Andres Freund
On Monday, April 09, 2012 05:32:43 PM Noah Misch wrote: On Mon, Apr 09, 2012 at 03:35:06PM +0200, Andres Freund wrote: On Monday, April 09, 2012 03:25:36 PM Robert Haas wrote: contrib/xml2 isn't doing us much harm beyond being an ugly wart, but non- SELECT rules are a land mine for the

Re: [HACKERS] Deprecating non-select rules (was Re: Last gasp)

2012-04-10 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: Here is what I know and what comes to my mind right now: 1. anything but INSTEAD rules are unsafe How so? I agree that volatile functions are problematic, but unless there's one of those in the picture I think rules work pretty much as documented.

[HACKERS] Deprecating non-select rules (was Re: Last gasp)

2012-04-09 Thread Andres Freund
On Monday, April 09, 2012 03:25:36 PM Robert Haas wrote: contrib/xml2 isn't doing us much harm beyond being an ugly wart, but non- SELECT rules are a land mine for the unwary at best. Which we could start deprecating now btw. since INSTEAD triggers landed in 9.1. There were quite some use-cases

Re: [HACKERS] Deprecating non-select rules (was Re: Last gasp)

2012-04-09 Thread Noah Misch
On Mon, Apr 09, 2012 at 03:35:06PM +0200, Andres Freund wrote: On Monday, April 09, 2012 03:25:36 PM Robert Haas wrote: contrib/xml2 isn't doing us much harm beyond being an ugly wart, but non- SELECT rules are a land mine for the unwary at best. Which we could start deprecating now btw.

Re: [HACKERS] Deprecating non-select rules (was Re: Last gasp)

2012-04-09 Thread Robert Haas
On Mon, Apr 9, 2012 at 11:32 AM, Noah Misch n...@leadboat.com wrote: On Mon, Apr 09, 2012 at 03:35:06PM +0200, Andres Freund wrote: On Monday, April 09, 2012 03:25:36 PM Robert Haas wrote: contrib/xml2 isn't doing us much harm beyond being an ugly wart, but non- SELECT rules are a land mine