Re: [HACKERS] Fix a typo in snapmgr.c

2017-06-24 Thread Simon Riggs
On 23 June 2017 at 19:25, Andres Freund wrote: > On 2017-06-23 19:21:57 +0100, Simon Riggs wrote: >> On 23 June 2017 at 08:23, Simon Riggs wrote: >> > On 23 June 2017 at 08:21, Andres Freund wrote: >> >> On 2017-06-07 10:17:31

Re: [HACKERS] Fix a typo in snapmgr.c

2017-06-23 Thread Andres Freund
On 2017-06-23 19:21:57 +0100, Simon Riggs wrote: > On 23 June 2017 at 08:23, Simon Riggs wrote: > > On 23 June 2017 at 08:21, Andres Freund wrote: > >> On 2017-06-07 10:17:31 -0700, Andres Freund wrote: > >>> On 2017-05-08 09:12:13 -0400, Tom Lane

Re: [HACKERS] Fix a typo in snapmgr.c

2017-06-23 Thread Simon Riggs
On 23 June 2017 at 08:23, Simon Riggs wrote: > On 23 June 2017 at 08:21, Andres Freund wrote: >> On 2017-06-07 10:17:31 -0700, Andres Freund wrote: >>> On 2017-05-08 09:12:13 -0400, Tom Lane wrote: >>> > Simon Riggs writes: >>> >

Re: [HACKERS] Fix a typo in snapmgr.c

2017-06-23 Thread Simon Riggs
On 23 June 2017 at 08:21, Andres Freund wrote: > On 2017-06-07 10:17:31 -0700, Andres Freund wrote: >> On 2017-05-08 09:12:13 -0400, Tom Lane wrote: >> > Simon Riggs writes: >> > > So rearranged code a little to keep it lean. >> > >> > Didn't you break

Re: [HACKERS] Fix a typo in snapmgr.c

2017-06-23 Thread Andres Freund
On 2017-06-07 10:17:31 -0700, Andres Freund wrote: > On 2017-05-08 09:12:13 -0400, Tom Lane wrote: > > Simon Riggs writes: > > > So rearranged code a little to keep it lean. > > > > Didn't you break it with that? As it now stands, the memcpy will > > copy the nonzero

Re: [HACKERS] Fix a typo in snapmgr.c

2017-06-07 Thread Masahiko Sawada
On Thu, Jun 8, 2017 at 2:17 AM, Andres Freund wrote: > On 2017-05-08 09:12:13 -0400, Tom Lane wrote: >> Simon Riggs writes: >> > So rearranged code a little to keep it lean. >> >> Didn't you break it with that? As it now stands, the memcpy will >> copy

Re: [HACKERS] Fix a typo in snapmgr.c

2017-06-07 Thread Andres Freund
On 2017-05-08 09:12:13 -0400, Tom Lane wrote: > Simon Riggs writes: > > So rearranged code a little to keep it lean. > > Didn't you break it with that? As it now stands, the memcpy will > copy the nonzero value. I've not seen a fix and/or alleviating comment about this

Re: [HACKERS] Fix a typo in snapmgr.c

2017-05-08 Thread Masahiko Sawada
On Mon, May 8, 2017 at 10:12 PM, Tom Lane wrote: > Simon Riggs writes: >> So rearranged code a little to keep it lean. > > Didn't you break it with that? As it now stands, the memcpy will > copy the nonzero value. > Right, I'd missed it. That code

Re: [HACKERS] Fix a typo in snapmgr.c

2017-05-08 Thread Tom Lane
Simon Riggs writes: > So rearranged code a little to keep it lean. Didn't you break it with that? As it now stands, the memcpy will copy the nonzero value. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Fix a typo in snapmgr.c

2017-05-08 Thread Masahiko Sawada
On Mon, May 8, 2017 at 4:57 PM, Simon Riggs wrote: > On 8 May 2017 at 06:28, Masahiko Sawada wrote: >> Hi, >> >> Attached patch for $subject. >> >> s/recovey/recovery/ > > There was a typo, but the comment itself was slightly wrong and also >

Re: [HACKERS] Fix a typo in snapmgr.c

2017-05-08 Thread Simon Riggs
On 8 May 2017 at 06:28, Masahiko Sawada wrote: > Hi, > > Attached patch for $subject. > > s/recovey/recovery/ There was a typo, but the comment itself was slightly wrong and also duplicated with another comment further down. So rearranged code a little to keep it lean.

[HACKERS] Fix a typo in snapmgr.c

2017-05-07 Thread Masahiko Sawada
Hi, Attached patch for $subject. s/recovey/recovery/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_snapmgr_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make