On 07/07/2015 02:56 AM, Tom Lane wrote:
Michael Paquier writes:
On Tue, Jul 7, 2015 at 4:19 AM, Heikki Linnakangas wrote:
Ok, committed that way.
Shoudn't this patch be backpatched? In the backbranches install.bat
does not work correctly with paths containing spaces.
I was about to ask t
Michael Paquier writes:
> On Tue, Jul 7, 2015 at 4:19 AM, Heikki Linnakangas wrote:
>> Ok, committed that way.
> Shoudn't this patch be backpatched? In the backbranches install.bat
> does not work correctly with paths containing spaces.
I was about to ask the same. AFAICS, the other scripts ha
On Tue, Jul 7, 2015 at 4:19 AM, Heikki Linnakangas wrote:
> On 07/06/2015 04:38 AM, Michael Paquier wrote:
>>
>> On Sat, Jul 4, 2015 at 3:57 AM, Heikki Linnakangas wrote:
>>>
>>> Hmm. Why is install.bat not like build.bat, i.e. just a thin wrapper that
>>> just calls install.pl, passing all argume
On 07/06/2015 04:38 AM, Michael Paquier wrote:
On Sat, Jul 4, 2015 at 3:57 AM, Heikki Linnakangas wrote:
Hmm. Why is install.bat not like build.bat, i.e. just a thin wrapper that
just calls install.pl, passing all arguments?
I guess we just haven't noticed it. And indeed it makes everything
mo
On Sat, Jul 4, 2015 at 3:57 AM, Heikki Linnakangas wrote:
> Hmm. Why is install.bat not like build.bat, i.e. just a thin wrapper that
> just calls install.pl, passing all arguments?
I guess we just haven't noticed it. And indeed it makes everything
more simple, and fixes as well the error reported
On 04/21/2015 04:02 PM, Michael Paquier wrote:
On Tue, Apr 21, 2015 at 4:33 PM, Asif Naeem wrote:
The v2 patch looks good to me, just a minor concern on usage message i.e.
C:\PG\postgresql\src\tools\msvc>install
Invalid command line options.
Usage: "install.bat [installtype]"
installtype: c
On Wed, Apr 22, 2015 at 12:40 AM, Asif Naeem wrote:
> Thank you Michael, latest patch looks good to me. I have changed its
> status to ready for committer.
>
Thanks!
--
Michael
Thank you Michael, latest patch looks good to me. I have changed its status
to ready for committer.
Regards,
Muhammad Asif Naeem
On Tue, Apr 21, 2015 at 6:02 PM, Michael Paquier
wrote:
>
>
> On Tue, Apr 21, 2015 at 4:33 PM, Asif Naeem wrote:
>
>> The v2 patch looks good to me, just a minor con
On Tue, Apr 21, 2015 at 4:33 PM, Asif Naeem wrote:
> The v2 patch looks good to me, just a minor concern on usage message i.e.
>
> C:\PG\postgresql\src\tools\msvc>install
>> Invalid command line options.
>> Usage: "install.bat [installtype]"
>> installtype: client
>
>
> It seems that there are t
The v2 patch looks good to me, just a minor concern on usage message i.e.
C:\PG\postgresql\src\tools\msvc>install
> Invalid command line options.
> Usage: "install.bat [installtype]"
> installtype: client
It seems that there are two install options i.e. client, all (any other
string other than
On Thu, Apr 16, 2015 at 5:40 PM, Asif Naeem wrote:
> Along with fixing the space in installation path, it is also changing the
> behavior of install script, why not just "if NOT [%1]==[] GOTO RUN_INSTALL",
> checking for "/?" seems good for help message but it seem not well handled
> in the script,
Hi Michael,
I spend spend time look into the patch. Good catch, I am also surprised to
see that current Windows install script don’t support spaces in the path.
Please see my findings as following i.e.
*Without the patch*
1.
> C:\PG\postgresql\src\tools\msvc>install "C:\PG\postgresql\inst with
Hi all,
When using install.bat with a path containing spaces, I got surprised
by a couple of errors.
1) First with this path:
$ install "c:\Program Files\pgsql"
I am getting the following error:
Files\pgsql""=="" was unexpected at this time.
This is caused by an incorrect evaluation of the first p
13 matches
Mail list logo
