Re: [HACKERS] Fractions in GUC variables

2014-12-21 Thread Michael Paquier
On Tue, Dec 16, 2014 at 12:19 AM, Peter Eisentraut wrote: > On 12/15/14 8:56 AM, Heikki Linnakangas wrote: >> Overall, I feel that this isn't really worth the trouble. We use >> fractions consistently now, so there isn't much room for confusion over >> what the current values mean. Using a percent

Re: [HACKERS] Fractions in GUC variables

2014-12-15 Thread Jim Nasby
On 12/7/14, 1:48 PM, John Gorman wrote: This patch implements the first wiki/Todo Configuration Files item "Consider normalizing fractions in postgresql.conf, perhaps using '%'". FWIW, I've reviewed this (should have read the thread first :/). It looks clean, passes make check and works as ad

Re: [HACKERS] Fractions in GUC variables

2014-12-15 Thread Bruce Momjian
On Mon, Dec 15, 2014 at 10:19:19AM -0500, Peter Eisentraut wrote: > > Overall, I feel that this isn't really worth the trouble. We use > > fractions consistently now, so there isn't much room for confusion over > > what the current values mean. Using a percentage might be more familiar > > for some

Re: [HACKERS] Fractions in GUC variables

2014-12-15 Thread Peter Eisentraut
On 12/15/14 8:56 AM, Heikki Linnakangas wrote: >> show cursor_tuple_fraction; --> 10% >> set cursor_tuple_fraction = .15; --> 15% >> set cursor_tuple_fraction = '33%'; --> 33% >> >> I tagged four configuration variables to display as percents. > > I'm not sure I agree that percentages are better t

Re: [HACKERS] Fractions in GUC variables

2014-12-15 Thread Heikki Linnakangas
On 12/07/2014 09:48 PM, John Gorman wrote: This patch implements the first wiki/Todo Configuration Files item "Consider normalizing fractions in postgresql.conf, perhaps using '%'". The "Fractions in GUC variables" discussion is here. http://www.postgresql.org/message-id/467132cf.9020...@enterp

Re: [HACKERS] Fractions in GUC variables

2014-12-07 Thread Michael Paquier
On Mon, Dec 8, 2014 at 4:48 AM, John Gorman wrote: > The attached patch applies cleanly against master and passes all regression > tests including two new tests in guc.sql. Please be sure to register your patch to the upcoming commit fest, this way it will not fall into oblivion and will get some

Re: [HACKERS] Fractions in GUC variables

2014-12-07 Thread Josh Berkus
On 12/07/2014 11:48 AM, John Gorman wrote: > > This patch implements the first wiki/Todo Configuration Files item > "Consider normalizing fractions in postgresql.conf, perhaps using '%'". > > The "Fractions in GUC variables" discussion is here. > Oh, this is nice! Thanks for working on it. -

[HACKERS] Fractions in GUC variables

2014-12-07 Thread John Gorman
This patch implements the first wiki/Todo Configuration Files item "Consider normalizing fractions in postgresql.conf, perhaps using '%'". The "Fractions in GUC variables" discussion is here. http://www.postgresql.org/message-id/467132cf.9020...@enterprisedb.com This patch implements expressing

Re: [HACKERS] Fractions in GUC variables

2008-03-11 Thread Bruce Momjian
Added to TODO: o Consider normalizing fractions in postgresql.conf, perhaps using '%' http://archives.postgresql.org/pgsql-hackers/2007-06/msg00550.php --- Heikki Linnakangas wrote: > We have t

Re: [HACKERS] Fractions in GUC variables

2007-07-16 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Heikki Linnakangas wrote: > We have these GUC variables that define a fraction of something: > > #autovacuum_vacuum_

Re: [HACKERS] Fractions in GUC variables

2007-06-15 Thread Jim Nasby
On Jun 14, 2007, at 7:21 AM, Heikki Linnakangas wrote: We have these GUC variables that define a fraction of something: #autovacuum_vacuum_scale_factor = 0.2 # fraction of rel size before # vacuum #autovacuum_analyze_scale_factor = 0.1 # fraction of rel

[HACKERS] Fractions in GUC variables

2007-06-14 Thread Heikki Linnakangas
We have these GUC variables that define a fraction of something: #autovacuum_vacuum_scale_factor = 0.2 # fraction of rel size before # vacuum #autovacuum_analyze_scale_factor = 0.1 # fraction of rel size before # a