On Fri, Feb 5, 2016 at 6:14 AM, Peter Geoghegan wrote:
> On Wed, Feb 3, 2016 at 11:31 AM, Robert Haas wrote:
>> Thanks for the review. I fixed the OID conflict, tweaked a few
>> comments, and committed this.
>
> Thanks. I noticed a tiny, preexisting typo in the string abbreviated
> key code. The
On Wed, Feb 3, 2016 at 11:31 AM, Robert Haas wrote:
> Thanks for the review. I fixed the OID conflict, tweaked a few
> comments, and committed this.
Thanks. I noticed a tiny, preexisting typo in the string abbreviated
key code. The attached patch fixes it.
--
Peter Geoghegan
diff --git a/src/b
On Sun, Jan 31, 2016 at 7:59 PM, Andreas Karlsson wrote:
> Nice work, I like your sorting patches.
Thanks. I like your reviews of my sorting patches. :-)
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.
On Sun, Jan 31, 2016 at 10:59 PM, Andreas Karlsson wrote:
> I have reviewed this now and I think this is a useful addition even though
> these indexes are less common. Consistent behavior is worth a lot in my mind
> and this patch is reasonably small.
>
> The patch no longer applies due to 1) oid
Hi,
I have reviewed this now and I think this is a useful addition even
though these indexes are less common. Consistent behavior is worth a lot
in my mind and this patch is reasonably small.
The patch no longer applies due to 1) oid collisions and 2) a trivial
conflict. When I fixed those t
On Thu, Jan 7, 2016 at 7:41 AM, Alvaro Herrera wrote:
> You're stealthily introducing a new abstraction called "string",
> including a typedef and DatumGetString support macros. Is that really
> necessary? Shouldn't it be discussed specifically? I don't necessarily
> oppose it as is, mainly bec
Peter Geoghegan wrote:
> We lack SortSupport for many character-like-type cases. In full, the
> cases within the core system are:
You're stealthily introducing a new abstraction called "string",
including a typedef and DatumGetString support macros. Is that really
necessary? Shouldn't it be disc
We lack SortSupport for many character-like-type cases. In full, the
cases within the core system are:
* char(n) opfamily (bpchar_ops).
* text_pattern_ops opfamily (includes text and varchar "pattern"
opclasses, which are generally recommended for accelerating LIKE
operator queries).
* bpchar_pa
