On Thu, Mar 10, 2011 at 11:25 AM, Robert Haas wrote:
> On Thu, Mar 10, 2011 at 10:59 AM, Tom Lane wrote:
>> Robert Haas writes:
>> Speaking of running scripts, I think we should run pgindent now.
>>
>>> Yeah, +1 for doing it as soon as Tom is at a good stopping point. It
>>> makes things a
Tom Lane wrote:
> I expect to be spending a whole lot of time reading collate and
> SSI code over the next few weeks, so I'm in favor of pgindent'ing
> that stuff first.
I've been running that throughout development, but it hasn't been
run after the last few changes. If you want the SSI files
On Thu, Mar 10, 2011 at 10:59 AM, Tom Lane wrote:
> Robert Haas writes:
> Speaking of running scripts, I think we should run pgindent now.
>
>> Yeah, +1 for doing it as soon as Tom is at a good stopping point. It
>> makes things a lot simpler later on.
>
> IIRC the argument for an early pgin
On 03/10/2011 10:33 AM, Robert Haas wrote:
On Thu, Mar 10, 2011 at 10:21 AM, Bruce Momjian wrote:
Tom Lane wrote:
Itagaki Takahiro writes:
I found trivial mistakes in the recently added files.
Will they fixed by some automated batches, or by manual?
- "Copyright (c) xxx-*2010*, PostgreSQL
Robert Haas writes:
Speaking of running scripts, I think we should run pgindent now.
> Yeah, +1 for doing it as soon as Tom is at a good stopping point. It
> makes things a lot simpler later on.
IIRC the argument for an early pgindent run was to standardize the new
code for easier review.
On Thu, Mar 10, 2011 at 16:50, Robert Haas wrote:
> On Thu, Mar 10, 2011 at 10:47 AM, Tom Lane wrote:
>> Bruce Momjian writes:
>>> Robert Haas wrote:
Speaking of running scripts, I think we should run pgindent now.
>>
>>> We usually do it during a late beta.
>>
>> Last time we did it early
On Thu, Mar 10, 2011 at 10:47 AM, Tom Lane wrote:
> Bruce Momjian writes:
>> Robert Haas wrote:
>>> Speaking of running scripts, I think we should run pgindent now.
>
>> We usually do it during a late beta.
>
> Last time we did it early and then again late, and that seemed to work
> well. I woul
Tom Lane wrote:
> Bruce Momjian writes:
> > Robert Haas wrote:
> >> Speaking of running scripts, I think we should run pgindent now.
>
> > We usually do it during a late beta.
>
> Last time we did it early and then again late, and that seemed to work
> well. I wouldn't object to a pgindent run
Bruce Momjian writes:
> Robert Haas wrote:
>> Speaking of running scripts, I think we should run pgindent now.
> We usually do it during a late beta.
Last time we did it early and then again late, and that seemed to work
well. I wouldn't object to a pgindent run now, but please sync with me
bef
Robert Haas wrote:
> On Thu, Mar 10, 2011 at 10:21 AM, Bruce Momjian wrote:
> > Tom Lane wrote:
> >> Itagaki Takahiro writes:
> >> > I found trivial mistakes in the recently added files.
> >> > Will they fixed by some automated batches, or by manual?
> >>
> >> > - "Copyright (c) xxx-*2010*, Postg
On Thu, Mar 10, 2011 at 10:21 AM, Bruce Momjian wrote:
> Tom Lane wrote:
>> Itagaki Takahiro writes:
>> > I found trivial mistakes in the recently added files.
>> > Will they fixed by some automated batches, or by manual?
>>
>> > - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group"
>
Tom Lane wrote:
> Itagaki Takahiro writes:
> > I found trivial mistakes in the recently added files.
> > Will they fixed by some automated batches, or by manual?
>
> > - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group"
> > in pg_collation.h, pg_foreign_table.h, basebackup.h, sync
Itagaki Takahiro writes:
> I found trivial mistakes in the recently added files.
> Will they fixed by some automated batches, or by manual?
> - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group"
> in pg_collation.h, pg_foreign_table.h, basebackup.h, syncrep.h,
> pg_backup_directo
On Thu, Mar 10, 2011 at 12:55, Robert Haas wrote:
> On Wed, Mar 9, 2011 at 8:33 PM, Itagaki Takahiro
> wrote:
>> I found trivial mistakes in the recently added files.
>> Will they fixed by some automated batches, or by manual?
> I think these should be fixed manually. The first might eventually
On Wed, Mar 9, 2011 at 8:33 PM, Itagaki Takahiro
wrote:
> I found trivial mistakes in the recently added files.
> Will they fixed by some automated batches, or by manual?
>
> - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group"
> in pg_collation.h, pg_foreign_table.h, basebackup.h, s
I found trivial mistakes in the recently added files.
Will they fixed by some automated batches, or by manual?
- "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group"
in pg_collation.h, pg_foreign_table.h, basebackup.h, syncrep.h,
pg_backup_directory.c and auth_delay.c.
- "IDENTIFICA
16 matches
Mail list logo
