Re: [HACKERS] Improve code in tidbitmap.c

Etsuro Fujita fujita.ets...@lab.ntt.co.jp writes: I'd like to do the complementary explanation of this. In tbm_union_page() and tbm_intersect_page() in tidbitmap.c, WORDS_PER_PAGE is used in the scan of a lossy chunk, instead of WORDS_PER_CHUNK, where these macros are defined as: /* number

Re: [HACKERS] Improve code in tidbitmap.c

I'd like to do the complementary explanation of this. In tbm_union_page() and tbm_intersect_page() in tidbitmap.c, WORDS_PER_PAGE is used in the scan of a lossy chunk, instead of WORDS_PER_CHUNK, where these macros are defined as: /* number of active words for an exact page: */ #define

Re: [HACKERS] Improve code in tidbitmap.c

On Fri, Nov 15, 2013 at 12:50 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: I think that, as a secondary effect of the patch, the scan would be performed a bit efficiently. Hi Etsuro, Would you be able to supply some benchmarks of a work load which benefits from this change?

[HACKERS] Improve code in tidbitmap.c

Hi, ISTM the code in tidbitmap.c should be improved. Patch attached. I think this patch increases the efficiency a bit. Thanks, Best regards, Etsuro Fujita diff --git a/src/backend/nodes/tidbitmap.c b/src/backend/nodes/tidbitmap.c index 3ef0112..43628ac 100644 ---