Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-12-04 Thread Magnus Hagander
On Mon, Dec 2, 2013 at 10:42 PM, Peter Eisentraut wrote: > On 11/19/13, 11:30 PM, Peter Geoghegan wrote: > >>> +1 from me. > >> > > >> > > >> > That's +1 for *not* including this? > > Right. > > I agree with not including this. > > If you're looking for more of those, here's another +1 for not in

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-12-02 Thread Peter Eisentraut
On 11/19/13, 11:30 PM, Peter Geoghegan wrote: >>> +1 from me. >> > >> > >> > That's +1 for *not* including this? > Right. I agree with not including this. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailp

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-19 Thread Peter Geoghegan
On Tue, Nov 19, 2013 at 12:12 PM, Jeff Janes wrote: >> > The same idea was proposed before but not committed because >> > Itagaki thought that pg_stat_statements view should report only raw >> > values. >> > Please read the following thread. I have the same feeling with him. >> > Anyway we should

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-19 Thread Jeff Janes
On Mon, Nov 18, 2013 at 10:56 AM, Peter Geoghegan wrote: > On Mon, Nov 18, 2013 at 10:49 AM, Fujii Masao > wrote: > > The same idea was proposed before but not committed because > > Itagaki thought that pg_stat_statements view should report only raw > values. > > Please read the following thread

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread Peter Geoghegan
On Mon, Nov 18, 2013 at 10:08 PM, KONDO Mitsumasa wrote: > I regret past decision of Itagaki-san's patch, and improvement might not be > possible. However, we can change it, if we get have logical reason to change > it. I suppose so. >> I don't think that the tool needs to be expensive. If selec

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread KONDO Mitsumasa
(2013/11/19 12:03), Peter Geoghegan wrote: On Mon, Nov 18, 2013 at 6:12 PM, KONDO Mitsumasa wrote: I confirmed that Itagaki-san and Mr Cerdic disscution. He said that raw values be just simple. However, were his changes just simple? I cannot understand his aesthetics sense and also you, too:-(

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread Peter Geoghegan
On Mon, Nov 18, 2013 at 6:12 PM, KONDO Mitsumasa wrote: > I confirmed that Itagaki-san and Mr Cerdic disscution. He said that raw > values be just simple. However, were his changes just simple? I cannot > understand his aesthetics sense and also you, too:-( > It's too complicated, and do you know

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread KONDO Mitsumasa
(2013/11/19 11:12), KONDO Mitsumasa wrote: (2013/11/19 3:56), Peter Geoghegan wrote: On Mon, Nov 18, 2013 at 10:49 AM, Fujii Masao wrote: The same idea was proposed before but not committed because Itagaki thought that pg_stat_statements view should report only raw values. Please read the foll

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread KONDO Mitsumasa
(2013/11/19 3:56), Peter Geoghegan wrote: On Mon, Nov 18, 2013 at 10:49 AM, Fujii Masao wrote: The same idea was proposed before but not committed because Itagaki thought that pg_stat_statements view should report only raw values. Please read the following thread. I have the same feeling with h

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread Peter Geoghegan
On Mon, Nov 18, 2013 at 10:49 AM, Fujii Masao wrote: > The same idea was proposed before but not committed because > Itagaki thought that pg_stat_statements view should report only raw values. > Please read the following thread. I have the same feeling with him. > Anyway we should listen to more o

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread Fujii Masao
On Mon, Nov 18, 2013 at 8:36 PM, KONDO Mitsumasa wrote: > (2013/11/18 20:16), Haribabu kommi wrote: >> >> On 18 October 2013 13:35 KONDO Mitsumasa wrote: >>> >>> This patch conflicts pg_stat_statement_min_max_exectime patch which I >>> submitted, and pg_stat_statement_min_max_exectime patch also a

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread KONDO Mitsumasa
(2013/11/18 20:16), Haribabu kommi wrote: On 18 October 2013 13:35 KONDO Mitsumasa wrote: This patch conflicts pg_stat_statement_min_max_exectime patch which I submitted, and pg_stat_statement_min_max_exectime patch also adds new columns which are min_time and max_time. So I'd like to change it

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread Haribabu kommi
On 18 October 2013 13:35 KONDO Mitsumasa wrote: > Hi, > > I submit improvement of pg_stat_statement usage patch in CF3. > > In pg_stat_statement, I think buffer hit ratio is very important value. > However, it is difficult to calculate it, and it need complicated SQL. > This patch makes it more

[HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-10-18 Thread KONDO Mitsumasa
Hi, I submit improvement of pg_stat_statement usage patch in CF3. In pg_stat_statement, I think buffer hit ratio is very important value. However, it is difficult to calculate it, and it need complicated SQL. This patch makes it more simple usage and documentation. > -bench=# SELECT query, call