On 07/09/2015 06:29 AM, Heikki Linnakangas wrote:
On 07/09/2015 04:50 AM, Michael Paquier wrote:
Except that this patch looks good to me. Thanks for the black magic on
stdout/stderr handling.
Thanks, fixed the parenthesis and committed. The missing --debug is a
separate issue.
What
On Thu, Jul 9, 2015 at 9:43 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Heikki Linnakangas hlinn...@iki.fi writes:
Pushed, thanks.
Shouldn't we consider back-patching these improvements into 9.5 and 9.4?
ISTM the main point is to help debug buildfarm failures, and we won't be
getting much benefit
On 07/09/2015 04:50 AM, Michael Paquier wrote:
On Thu, Jul 9, 2015 at 12:49 AM, Heikki Linnakangas wrote:
Looking at the manual page of Test::More, it looks like you could change
where the perl script's STDOUT and STDERR point to, because Test::More
takes
a copy of them (when? at program
On Thu, Jul 9, 2015 at 7:29 PM, Heikki Linnakangas hlinn...@iki.fi wrote:
Thanks, fixed the parenthesis and committed.
Thanks. I imagine that this is going to need some tuning with the
buildfarm before this becomes really useful. I will re-enable the TAP
tests of hamster once that's the case.
On 07/09/2015 04:09 PM, Michael Paquier wrote:
On Thu, Jul 9, 2015 at 7:29 PM, Heikki Linnakangas hlinn...@iki.fi wrote:
The missing --debug is a separate issue.
I won't argue against that, but is it worth creating a new thread just
for this one-liner? The local mode of pg_rewind uses it
Heikki Linnakangas hlinn...@iki.fi writes:
Pushed, thanks.
Shouldn't we consider back-patching these improvements into 9.5 and 9.4?
ISTM the main point is to help debug buildfarm failures, and we won't be
getting much benefit if only one-third of such reports have decent
logging.
On Thu, Jul 9, 2015 at 10:43 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Heikki Linnakangas hlinn...@iki.fi writes:
Pushed, thanks.
Shouldn't we consider back-patching these improvements into 9.5 and 9.4?
ISTM the main point is to help debug buildfarm failures, and we won't be
getting much
On Wed, Jul 8, 2015 at 6:10 AM, Heikki Linnakangas hlinn...@iki.fi wrote:
On 06/25/2015 07:14 AM, Michael Paquier wrote:
After looking at the issues with the TAP test suite that hamster faced
a couple of days ago, which is what has been discussed on this thread:
On 07/08/2015 11:26 AM, Michael Paquier wrote:
On Wed, Jul 8, 2015 at 6:10 AM, Heikki Linnakangas hlinn...@iki.fi wrote:
* whenever a test case is reported as success/fail.
Just to be sure, does this concern the ok/not ok messages printed
out by each test run? Or is it a custom message that
On 06/25/2015 07:14 AM, Michael Paquier wrote:
After looking at the issues with the TAP test suite that hamster faced
a couple of days ago, which is what has been discussed on this thread:
http://www.postgresql.org/message-id/13002.1434307...@sss.pgh.pa.us
I have developed a patch to improve
On Thu, June 25, 2015 06:14, Michael Paquier wrote:
I have developed a patch to improve log capture of the TAP tests by
being able to collect stderr and stdout output of each command run in
the tests by using more extensively IPC::Run::run (instead of system()
IPC::Run is not in perl core and
On Thu, Jun 25, 2015 at 3:59 PM, Erik Rijkers e...@xs4all.nl wrote:
IPC::Run is not in perl core and will not always be available.
It looks like this patch doesn't take this into account (when no IPC::Run
skip the test or whatever)
Shouldn't that be changed?
Yes, there have been discussions
Hi all,
After looking at the issues with the TAP test suite that hamster faced
a couple of days ago, which is what has been discussed on this thread:
http://www.postgresql.org/message-id/13002.1434307...@sss.pgh.pa.us
I have developed a patch to improve log capture of the TAP tests by
being able
13 matches
Mail list logo
