Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-19 Thread Kris Jurka
On Tue, 19 Apr 2011, Tom Lane wrote: Kris Jurka bo...@ejurka.com writes: On Mon, 18 Apr 2011, Mike Fowler wrote: As there seems to be a consensus forming for fixing the JDBC driver, I've taken the liberty do so at the risk of being shot down. The patch is fairly straightforward, just

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-19 Thread Tom Lane
Kris Jurka bo...@ejurka.com writes: On Tue, 19 Apr 2011, Tom Lane wrote: For purposes of the notes in the server-side fix, could you state which JDBC driver versions these changes will first appear in? This is in 9.1dev-900 and won't be backpatched. OK, thanks. I've committed a patch to

[HACKERS] JDBC connections to 9.1

2011-04-18 Thread Steve Singer
I'm getting JDBC exceptions when I try to connect to 9.1 (master) with the postgresql-9.0-801.jdbc3.jar I don't have this issue with 9.0. There is nothing obvious at http://jdbc.postgresql.org or in the 9.1 alpha release notes that indicate a newer JDBC driver will be required. Have other

Re: [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Tom Lane
Steve Singer ssin...@ca.afilias.info writes: I'm getting JDBC exceptions when I try to connect to 9.1 (master) with the postgresql-9.0-801.jdbc3.jar I don't have this issue with 9.0. Hmm, what shows up in the postmaster log? regards, tom lane -- Sent via

Re: [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Bernd Helmle
--On 18. April 2011 09:44:38 -0400 Tom Lane t...@sss.pgh.pa.us wrote: I'm getting JDBC exceptions when I try to connect to 9.1 (master) with the postgresql-9.0-801.jdbc3.jar I don't have this issue with 9.0. Hmm, what shows up in the postmaster log? A quick check with an application here

Re: [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Steve Singer
On 11-04-18 09:44 AM, Tom Lane wrote: Steve Singerssin...@ca.afilias.info writes: I'm getting JDBC exceptions when I try to connect to 9.1 (master) with the postgresql-9.0-801.jdbc3.jar I don't have this issue with 9.0. Hmm, what shows up in the postmaster log?

Re: [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Devrim GÜNDÜZ
On Mon, 2011-04-18 at 16:17 +0200, Bernd Helmle wrote: Hmm, seems it stumbles while reading client_encoding This is probably similar to what I had a couple weeks ago. With today's new minor releases, I get: $ psql psql: invalid connection option client_encoding (I was getting another

Re: [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Bernd Helmle
--On 18. April 2011 16:17:57 +0200 Bernd Helmle maili...@oopsware.de wrote: 16:09:47.942 (1) =BE ParameterStatus(client_encoding = UTF8) org.postgresql.util.PSQLException: Protocol error. Session setup failed. at

Re: [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Tom Lane
Bernd Helmle maili...@oopsware.de writes: If i am reading it correct, it reads UTF8 from the backend, while expecting UNICODE only. Not sure what change has caused this, though. I am --- when I redid the GUC assign_hook logic a few weeks ago, I changed the client_encoding code so that it shows

Re: [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Robert Haas
On Mon, Apr 18, 2011 at 10:57 AM, Tom Lane t...@sss.pgh.pa.us wrote: Bernd Helmle maili...@oopsware.de writes: If i am reading it correct, it reads UTF8 from the backend, while expecting UNICODE only. Not sure what change has caused this, though. I am --- when I redid the GUC assign_hook

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Dave Cramer
On Mon, Apr 18, 2011 at 10:57 AM, Tom Lane t...@sss.pgh.pa.us wrote: Bernd Helmle maili...@oopsware.de writes: If i am reading it correct, it reads UTF8 from the backend, while expecting UNICODE only. Not sure what change has caused this, though. I am --- when I redid the GUC assign_hook

Re: [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: I changed the client_encoding code so that it shows the normalized (official) name of the encoding, not whatever random string the client sent over. For instance, previous versions: regression=# set client_encoding = 'UnIcOdE'; SET The whole area of

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Mike Fowler
On 18/04/11 15:57, Tom Lane wrote: Bernd Helmlemaili...@oopsware.de writes: If i am reading it correct, it reads UTF8 from the backend, while expecting UNICODE only. Not sure what change has caused this, though. I am --- when I redid the GUC assign_hook logic a few weeks ago, I changed the

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Dave Cramer
On Mon, Apr 18, 2011 at 11:14 AM, Mike Fowler m...@mlfowler.com wrote: On 18/04/11 15:57, Tom Lane wrote: Bernd Helmlemaili...@oopsware.de  writes: If i am reading it correct, it reads UTF8 from the backend, while expecting UNICODE only. Not sure what change has caused this, though. I am

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Tom Lane
Dave Cramer p...@fastcrypt.com writes: On Mon, Apr 18, 2011 at 10:57 AM, Tom Lane t...@sss.pgh.pa.us wrote: I wasn't aware that JDBC would fail on that.  It's pretty annoying that it does, but maybe we should grin and bear it, ie revert the change to canonicalize the GUC's value? Older

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Tom Lane
Mike Fowler m...@mlfowler.com writes: On 18/04/11 15:57, Tom Lane wrote: I am --- when I redid the GUC assign_hook logic a few weeks ago, I changed the client_encoding code so that it shows the normalized (official) name of the encoding, not whatever random string the client sent over. For

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Dave Cramer
On Mon, Apr 18, 2011 at 11:24 AM, Tom Lane t...@sss.pgh.pa.us wrote: Dave Cramer p...@fastcrypt.com writes: On Mon, Apr 18, 2011 at 10:57 AM, Tom Lane t...@sss.pgh.pa.us wrote: I wasn't aware that JDBC would fail on that.  It's pretty annoying that it does, but maybe we should grin and bear

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Tom Lane
Dave Cramer p...@fastcrypt.com writes: On Mon, Apr 18, 2011 at 11:24 AM, Tom Lane t...@sss.pgh.pa.us wrote: Yeah. I'm thinking what we should do here is revert the change, with a note in the source about why, and also change the JDBC driver to send and expect UTF8 not UNICODE (which as Kevin

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Andrew Dunstan
On 04/18/2011 11:25 AM, Tom Lane wrote: What concerns me most is that (assuming my dates are right) the JDBC driver has been broken for 11 days and no one noticed. This would lead me to believe that there is no JDBC build server. What would it take to set one up? +1 for doing something

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Mike Fowler
On 18/04/11 17:35, Andrew Dunstan wrote: On 04/18/2011 11:25 AM, Tom Lane wrote: What concerns me most is that (assuming my dates are right) the JDBC driver has been broken for 11 days and no one noticed. This would lead me to believe that there is no JDBC build server. What would it take

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Mike Fowler
On 18/04/11 17:12, Tom Lane wrote: Dave Cramerp...@fastcrypt.com writes: Well initially my concern was that people would have a challenge in the case where they had to re-certify their application if we made this change, however I realize they will have to do this anyway since upgrading to 9.1

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Kris Jurka
On Mon, 18 Apr 2011, Mike Fowler wrote: On 18/04/11 17:12, Tom Lane wrote: Dave Cramerp...@fastcrypt.com writes: Well initially my concern was that people would have a challenge in the case where they had to re-certify their application if we made this change, however I realize they will

Re: [JDBC] [HACKERS] JDBC connections to 9.1

2011-04-18 Thread Tom Lane
Kris Jurka bo...@ejurka.com writes: On Mon, 18 Apr 2011, Mike Fowler wrote: As there seems to be a consensus forming for fixing the JDBC driver, I've taken the liberty do so at the risk of being shot down. The patch is fairly straightforward, just changing UNICODE to UTF8 in a number of