Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-08 Thread Masahiko Sawada
On Tue, May 9, 2017 at 1:26 AM, Petr Jelinek wrote: > On 08/05/17 17:52, Masahiko Sawada wrote: >> On Fri, May 5, 2017 at 8:13 PM, Petr Jelinek >> wrote: >>> On 03/05/17 13:23, Erik Rijkers wrote: On 2017-05-03 08:17, Petr Jelinek wrote: > On 02/05/17 20:43, Robert Haas wrote: >> On

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-08 Thread Petr Jelinek
On 08/05/17 18:12, Peter Eisentraut wrote: > On 5/5/17 07:13, Petr Jelinek wrote: >> Yes that's different thing that we've been discussing a bit in snapbuild >> woes thread. >> >>> the 'TRAP: FailedAssertion in pgstat.c' anymore. >>> >>> (If there is any other configuration of patches worth testing

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-08 Thread Petr Jelinek
On 08/05/17 17:52, Masahiko Sawada wrote: > On Fri, May 5, 2017 at 8:13 PM, Petr Jelinek > wrote: >> On 03/05/17 13:23, Erik Rijkers wrote: >>> On 2017-05-03 08:17, Petr Jelinek wrote: On 02/05/17 20:43, Robert Haas wrote: > On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut >>> >> cod

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-08 Thread Peter Eisentraut
On 5/5/17 07:13, Petr Jelinek wrote: > Yes that's different thing that we've been discussing a bit in snapbuild > woes thread. > >> the 'TRAP: FailedAssertion in pgstat.c' anymore. >> >> (If there is any other configuration of patches worth testing please let >> me know) > > Thanks, so the patch

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-08 Thread Masahiko Sawada
On Fri, May 5, 2017 at 8:13 PM, Petr Jelinek wrote: > On 03/05/17 13:23, Erik Rijkers wrote: >> On 2017-05-03 08:17, Petr Jelinek wrote: >>> On 02/05/17 20:43, Robert Haas wrote: On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut >> > code path that calls CommitTransactionCommand() should

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-05 Thread Petr Jelinek
On 03/05/17 13:23, Erik Rijkers wrote: > On 2017-05-03 08:17, Petr Jelinek wrote: >> On 02/05/17 20:43, Robert Haas wrote: >>> On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut > code path that calls CommitTransactionCommand() should have one, no? >>> >>> Is there anything left to be committe

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-05 Thread Noah Misch
On Wed, May 03, 2017 at 01:23:19PM +0200, Erik Rijkers wrote: > On 2017-05-03 08:17, Petr Jelinek wrote: > >On 02/05/17 20:43, Robert Haas wrote: > >>On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut > > >>>code path that calls CommitTransactionCommand() should have one, no? > >> > >>Is there anyt

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-03 Thread Erik Rijkers
On 2017-05-03 08:17, Petr Jelinek wrote: On 02/05/17 20:43, Robert Haas wrote: On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut code path that calls CommitTransactionCommand() should have one, no? Is there anything left to be committed here? Afaics the fix was not committed. Peter wante

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-02 Thread Petr Jelinek
On 02/05/17 20:43, Robert Haas wrote: > On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut > wrote: >> On 4/16/17 16:11, Petr Jelinek wrote: >>> Yeah it is, it needs to be fenced to happen only after commit, which is >>> not guaranteed at the point of code, we probably need to put the >>> pgstat_re

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-05-02 Thread Robert Haas
On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut wrote: > On 4/16/17 16:11, Petr Jelinek wrote: >> Yeah it is, it needs to be fenced to happen only after commit, which is >> not guaranteed at the point of code, we probably need to put the >> pgstat_report_stat() inside the if above after the >> C

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-04-20 Thread Peter Eisentraut
On 4/16/17 16:11, Petr Jelinek wrote: > Yeah it is, it needs to be fenced to happen only after commit, which is > not guaranteed at the point of code, we probably need to put the > pgstat_report_stat() inside the if above after the > CommitTransactionCommand() (that will make it report stats for ch

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-04-17 Thread Erik Rijkers
On 2017-04-17 15:59, Stas Kelvich wrote: On 17 Apr 2017, at 10:30, Erik Rijkers wrote: On 2017-04-16 20:41, Andres Freund wrote: On 2017-04-16 10:46:21 +0200, Erik Rijkers wrote: On 2017-04-15 04:47, Erik Rijkers wrote: > > 0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch + > 00

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-04-17 Thread Stas Kelvich
> On 17 Apr 2017, at 10:30, Erik Rijkers wrote: > > On 2017-04-16 20:41, Andres Freund wrote: >> On 2017-04-16 10:46:21 +0200, Erik Rijkers wrote: >>> On 2017-04-15 04:47, Erik Rijkers wrote: >>> > >>> > 0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch + >>> > 0002-Don-t-use-on-dis

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-04-17 Thread Erik Rijkers
On 2017-04-16 20:41, Andres Freund wrote: On 2017-04-16 10:46:21 +0200, Erik Rijkers wrote: On 2017-04-15 04:47, Erik Rijkers wrote: > > 0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch + > 0002-Don-t-use-on-disk-snapshots-for-snapshot-export-in-l.patch+ > 0003-Prevent-snapshot-bui

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-04-16 Thread Petr Jelinek
On 16/04/17 20:41, Andres Freund wrote: > On 2017-04-16 10:46:21 +0200, Erik Rijkers wrote: >> On 2017-04-15 04:47, Erik Rijkers wrote: >>> >>> 0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch + >>> 0002-Don-t-use-on-disk-snapshots-for-snapshot-export-in-l.patch+ >>> 0003-Prevent-snap

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-04-16 Thread Andres Freund
On 2017-04-16 10:46:21 +0200, Erik Rijkers wrote: > On 2017-04-15 04:47, Erik Rijkers wrote: > > > > 0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch + > > 0002-Don-t-use-on-disk-snapshots-for-snapshot-export-in-l.patch+ > > 0003-Prevent-snapshot-builder-xmin-from-going-backwards.pat

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-04-16 Thread Erik Rijkers
On 2017-04-15 04:47, Erik Rijkers wrote: 0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch + 0002-Don-t-use-on-disk-snapshots-for-snapshot-export-in-l.patch+ 0003-Prevent-snapshot-builder-xmin-from-going-backwards.patch + 0004-Fix-xl_running_xacts-usage-in-snapshot-builder.patch

[HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

2017-04-14 Thread Erik Rijkers
Testing logical replication, with the following patches on top of yesterday's master: 0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch + 0002-Don-t-use-on-disk-snapshots-for-snapshot-export-in-l.patch+ 0003-Prevent-snapshot-builder-xmin-from-going-backwards.patch + 0004-Fix-xl_r