Re: [HACKERS] Make pg_basebackup -x stream the default

2017-01-09 Thread Michael Paquier
On Tue, Jan 10, 2017 at 12:05 AM, Magnus Hagander wrote: > OK. Pushed. I agree it made it more readable, if nothing else. Thanks. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Make pg_basebackup -x stream the default

2017-01-09 Thread Magnus Hagander
On Sat, Jan 7, 2017 at 1:32 PM, Michael Paquier wrote: > On Sat, Jan 7, 2017 at 12:04 AM, Magnus Hagander > wrote: > > On Wed, Jan 4, 2017 at 10:43 AM, Magnus Hagander > > wrote: > >> Meh, just as I was going to respond

Re: [HACKERS] Make pg_basebackup -x stream the default

2017-01-07 Thread Michael Paquier
On Sat, Jan 7, 2017 at 12:04 AM, Magnus Hagander wrote: > On Wed, Jan 4, 2017 at 10:43 AM, Magnus Hagander > wrote: >> Meh, just as I was going to respond "committed" I noticed this second >> round of review comments. Apologies, pushed without that. >>

Re: [HACKERS] Make pg_basebackup -x stream the default

2017-01-06 Thread Magnus Hagander
On Wed, Jan 4, 2017 at 10:43 AM, Magnus Hagander wrote: > > > On Sun, Jan 1, 2017 at 12:47 AM, Michael Paquier < > michael.paqu...@gmail.com> wrote: > >> On Sat, Dec 31, 2016 at 9:24 PM, Magnus Hagander >> wrote: >> > On Tue, Dec 20, 2016 at 11:53 PM,

Re: [HACKERS] Make pg_basebackup -x stream the default

2017-01-04 Thread Magnus Hagander
On Sun, Jan 1, 2017 at 12:47 AM, Michael Paquier wrote: > On Sat, Dec 31, 2016 at 9:24 PM, Magnus Hagander > wrote: > > On Tue, Dec 20, 2016 at 11:53 PM, Michael Paquier > > wrote: > >> Recovery tests are broken by this

Re: [HACKERS] Make pg_basebackup -x stream the default

2017-01-02 Thread Simon Riggs
On 31 December 2016 at 23:47, Michael Paquier wrote: > Other than that the patch looks good to me. Tests pass. +1 -- Simon Riggshttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-31 Thread Michael Paquier
On Sat, Dec 31, 2016 at 9:24 PM, Magnus Hagander wrote: > On Tue, Dec 20, 2016 at 11:53 PM, Michael Paquier > wrote: >> Recovery tests are broken by this patch, the backup() method in >> PostgresNode.pm uses pg_basebackup -x: >> sub backup >> { >>

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-31 Thread Magnus Hagander
On Tue, Dec 20, 2016 at 11:53 PM, Michael Paquier wrote: > On Tue, Dec 20, 2016 at 10:38 PM, Fujii Masao > wrote: > > On Mon, Dec 19, 2016 at 7:51 PM, Vladimir Rusinov > wrote: > >> The server must also be configured with

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-31 Thread Magnus Hagander
On Tue, Dec 20, 2016 at 2:38 PM, Fujii Masao wrote: > On Mon, Dec 19, 2016 at 7:51 PM, Vladimir Rusinov > wrote: > > > > On Sat, Dec 17, 2016 at 2:37 PM, Magnus Hagander > > wrote: > >> > >> Attached is an updated patch that does

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-20 Thread Michael Paquier
On Tue, Dec 20, 2016 at 10:38 PM, Fujii Masao wrote: > On Mon, Dec 19, 2016 at 7:51 PM, Vladimir Rusinov wrote: >> The server must also be configured with max_wal_senders set high >> enough to leave at least one session available for the backup. > > I

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-20 Thread Fujii Masao
On Mon, Dec 19, 2016 at 7:51 PM, Vladimir Rusinov wrote: > > On Sat, Dec 17, 2016 at 2:37 PM, Magnus Hagander > wrote: >> >> Attached is an updated patch that does this. As a bonus it simplifies the >> code a bit. I also fixed an error message that I

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-19 Thread Vladimir Rusinov
On Sat, Dec 17, 2016 at 2:37 PM, Magnus Hagander wrote: > Attached is an updated patch that does this. As a bonus it simplifies the > code a bit. I also fixed an error message that I missed updating in the > previous patch. looks good to me. Still applies cleanly at head

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-17 Thread Magnus Hagander
On Fri, Dec 16, 2016 at 6:35 PM, Fujii Masao wrote: > On Fri, Dec 16, 2016 at 11:36 PM, Magnus Hagander > wrote: > > On Thu, Dec 15, 2016 at 12:37 AM, Vladimir Rusinov > > wrote: > >> > >> Usability review > >> > >>

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-16 Thread Fujii Masao
On Fri, Dec 16, 2016 at 11:36 PM, Magnus Hagander wrote: > On Thu, Dec 15, 2016 at 12:37 AM, Vladimir Rusinov > wrote: >> >> Usability review >> >> >> >> >> Patch sounds like a good idea and does what it supposed to do. /me in DBA >> hat

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-16 Thread Magnus Hagander
On Thu, Dec 15, 2016 at 12:37 AM, Vladimir Rusinov wrote: > Usability review > > > > > Patch sounds like a good idea and does what it supposed to do. /me in DBA > hat will be happy to have it. > > However, it makes '-x' parameter a bit confusing/surprising:

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-15 Thread Peter Eisentraut
On 12/15/16 1:27 PM, Magnus Hagander wrote: > On Thu, Dec 15, 2016 at 7:23 PM, Peter Eisentraut > > wrote: > > On 11/8/16 12:45 PM, Magnus Hagander wrote: > > Per some discussions with a number of different

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-15 Thread Magnus Hagander
On Thu, Dec 15, 2016 at 7:36 PM, Joshua D. Drake wrote: > On 12/15/2016 10:23 AM, Peter Eisentraut wrote: > >> On 11/8/16 12:45 PM, Magnus Hagander wrote: >> >>> Per some discussions with a number of different people at pgconfeu, here >>> is a patch that changes the

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-15 Thread Joshua D. Drake
On 12/15/2016 10:23 AM, Peter Eisentraut wrote: On 11/8/16 12:45 PM, Magnus Hagander wrote: Per some discussions with a number of different people at pgconfeu, here is a patch that changes the default mode of pg_basebackup to be streaming the wal, as this is what most users would want -- and

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-15 Thread Magnus Hagander
On Thu, Dec 15, 2016 at 7:23 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 11/8/16 12:45 PM, Magnus Hagander wrote: > > Per some discussions with a number of different people at pgconfeu, here > > is a patch that changes the default mode of pg_basebackup to be > > streaming

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-15 Thread Peter Eisentraut
On 11/8/16 12:45 PM, Magnus Hagander wrote: > Per some discussions with a number of different people at pgconfeu, here > is a patch that changes the default mode of pg_basebackup to be > streaming the wal, as this is what most users would want -- and those > that don't want it have to make other

Re: [HACKERS] Make pg_basebackup -x stream the default

2016-12-14 Thread Vladimir Rusinov
Summary === Thank you for submission! I think it needs a bit more work to be even better. Please deal with '-x' argument and with wording in documentation. I'll set status to 'waiting on author' now. Submission review == Patch is in correct format. Patch applies cleanly

[HACKERS] Make pg_basebackup -x stream the default

2016-11-08 Thread Magnus Hagander
Per some discussions with a number of different people at pgconfeu, here is a patch that changes the default mode of pg_basebackup to be streaming the wal, as this is what most users would want -- and those that don't want it have to make other changes as well. Doing the "most safe" thing by