Re: [HACKERS] Mishandling of WCO constraints in direct foreign table modification

2017-07-25 Thread Etsuro Fujita
On 2017/07/25 5:35, Robert Haas wrote: On Fri, Jul 21, 2017 at 6:21 AM, Etsuro Fujita wrote: I mean constraints derived from WITH CHECK OPTIONs specified for parent views. We use the words "WITH CHECK OPTION constraints" in comments in nodeModifyTable.c, so the

Re: [HACKERS] Mishandling of WCO constraints in direct foreign table modification

2017-07-24 Thread Robert Haas
On Fri, Jul 21, 2017 at 6:21 AM, Etsuro Fujita wrote: > I mean constraints derived from WITH CHECK OPTIONs specified for parent > views. We use the words "WITH CHECK OPTION constraints" in comments in > nodeModifyTable.c, so the expression "CHECK OPTION constrains"

Re: [HACKERS] Mishandling of WCO constraints in direct foreign table modification

2017-07-21 Thread Etsuro Fujita
On 2017/07/21 17:18, Kyotaro HORIGUCHI wrote: At Fri, 21 Jul 2017 12:00:03 +0900, Etsuro Fujita wrote in <15aa9936-9bd8-c9e3-7ca1-394861073...@lab.ntt.co.jp> Attached is the second version which updated docs in postgres-fdw.sgml as well. !no local joins for

Re: [HACKERS] Mishandling of WCO constraints in direct foreign table modification

2017-07-21 Thread Kyotaro HORIGUCHI
At Fri, 21 Jul 2017 12:00:03 +0900, Etsuro Fujita wrote in <15aa9936-9bd8-c9e3-7ca1-394861073...@lab.ntt.co.jp> > On 2017/07/21 3:24, Robert Haas wrote: > > I think that's reasonable. This should be committed and back-patched > > to 9.6, right? > > Yeah, because

Re: [HACKERS] Mishandling of WCO constraints in direct foreign table modification

2017-07-20 Thread Etsuro Fujita
On 2017/07/21 3:24, Robert Haas wrote: I think that's reasonable. This should be committed and back-patched to 9.6, right? Yeah, because direct modify was introduced in 9.6. Attached is the second version which updated docs in postgres-fdw.sgml as well. Best regards, Etsuro Fujita ***

Re: [HACKERS] Mishandling of WCO constraints in direct foreign table modification

2017-07-20 Thread Robert Haas
On Thu, Jul 20, 2017 at 7:40 AM, Etsuro Fujita wrote: > Here is an example for $subject using postgres_fdw: > > postgres=# create foreign table foreign_tbl (a int, b int) server loopback > options (table_name 'base_tbl'); > CREATE FOREIGN TABLE > postgres=# create

[HACKERS] Mishandling of WCO constraints in direct foreign table modification

2017-07-20 Thread Etsuro Fujita
Here is an example for $subject using postgres_fdw: postgres=# create foreign table foreign_tbl (a int, b int) server loopback options (table_name 'base_tbl'); CREATE FOREIGN TABLE postgres=# create view rw_view as select * from foreign_tbl where a < b with check option; CREATE VIEW