Re: [HACKERS] Missing PG_INT32_MIN in numutils.c

2016-04-13 Thread Michael Paquier
On Wed, Apr 13, 2016 at 11:13 PM, Robert Haas wrote: > On Wed, Apr 13, 2016 at 10:11 AM, Tom Lane wrote: >> Robert Haas writes: >>> On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane wrote: I am not very convinced that this is an improvement, because you took what had been two hard-wired const

Re: [HACKERS] Missing PG_INT32_MIN in numutils.c

2016-04-13 Thread Robert Haas
On Wed, Apr 13, 2016 at 10:11 AM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane wrote: >>> I am not very convinced that this is an improvement, because you took >>> what had been two hard-wired constants and replaced them with a symbol >>> and a hard-wired co

Re: [HACKERS] Missing PG_INT32_MIN in numutils.c

2016-04-13 Thread Tom Lane
Robert Haas writes: > On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane wrote: >> I am not very convinced that this is an improvement, because you took >> what had been two hard-wired constants and replaced them with a symbol >> and a hard-wired constant.This is more prone to break, not less so. > I thi

Re: [HACKERS] Missing PG_INT32_MIN in numutils.c

2016-04-13 Thread Robert Haas
On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Apr 13, 2016 at 3:49 AM, Michael Paquier >> wrote: >>> While going through numutils.c I found the following thing: >>> --- a/src/backend/utils/adt/numutils.c >>> +++ b/src/backend/utils/adt/numutils.c >>> @@ -136,7

Re: [HACKERS] Missing PG_INT32_MIN in numutils.c

2016-04-13 Thread Tom Lane
Robert Haas writes: > On Wed, Apr 13, 2016 at 3:49 AM, Michael Paquier > wrote: >> While going through numutils.c I found the following thing: >> --- a/src/backend/utils/adt/numutils.c >> +++ b/src/backend/utils/adt/numutils.c >> @@ -136,7 +136,7 @@ pg_ltoa(int32 value, char *a) >> * Avoid proble

Re: [HACKERS] Missing PG_INT32_MIN in numutils.c

2016-04-13 Thread Michael Paquier
On Wed, Apr 13, 2016 at 8:57 PM, Robert Haas wrote: > On Wed, Apr 13, 2016 at 3:49 AM, Michael Paquier > wrote: >> Hi all, >> >> While going through numutils.c I found the following thing: >> --- a/src/backend/utils/adt/numutils.c >> +++ b/src/backend/utils/adt/numutils.c >> @@ -136,7 +136,7 @@ p

Re: [HACKERS] Missing PG_INT32_MIN in numutils.c

2016-04-13 Thread Robert Haas
On Wed, Apr 13, 2016 at 3:49 AM, Michael Paquier wrote: > Hi all, > > While going through numutils.c I found the following thing: > --- a/src/backend/utils/adt/numutils.c > +++ b/src/backend/utils/adt/numutils.c > @@ -136,7 +136,7 @@ pg_ltoa(int32 value, char *a) > * Avoid problems with the m

[HACKERS] Missing PG_INT32_MIN in numutils.c

2016-04-13 Thread Michael Paquier
Hi all, While going through numutils.c I found the following thing: --- a/src/backend/utils/adt/numutils.c +++ b/src/backend/utils/adt/numutils.c @@ -136,7 +136,7 @@ pg_ltoa(int32 value, char *a) * Avoid problems with the most negative integer not being representable * as a positive inte