On Wed, Apr 13, 2016 at 11:13 PM, Robert Haas wrote:
> On Wed, Apr 13, 2016 at 10:11 AM, Tom Lane wrote:
>> Robert Haas writes:
>>> On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane wrote:
I am not very convinced that this is an improvement, because you took
what had been two hard-wired const
On Wed, Apr 13, 2016 at 10:11 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane wrote:
>>> I am not very convinced that this is an improvement, because you took
>>> what had been two hard-wired constants and replaced them with a symbol
>>> and a hard-wired co
Robert Haas writes:
> On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane wrote:
>> I am not very convinced that this is an improvement, because you took
>> what had been two hard-wired constants and replaced them with a symbol
>> and a hard-wired constant.This is more prone to break, not less so.
> I thi
On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Wed, Apr 13, 2016 at 3:49 AM, Michael Paquier
>> wrote:
>>> While going through numutils.c I found the following thing:
>>> --- a/src/backend/utils/adt/numutils.c
>>> +++ b/src/backend/utils/adt/numutils.c
>>> @@ -136,7
Robert Haas writes:
> On Wed, Apr 13, 2016 at 3:49 AM, Michael Paquier
> wrote:
>> While going through numutils.c I found the following thing:
>> --- a/src/backend/utils/adt/numutils.c
>> +++ b/src/backend/utils/adt/numutils.c
>> @@ -136,7 +136,7 @@ pg_ltoa(int32 value, char *a)
>> * Avoid proble
On Wed, Apr 13, 2016 at 8:57 PM, Robert Haas wrote:
> On Wed, Apr 13, 2016 at 3:49 AM, Michael Paquier
> wrote:
>> Hi all,
>>
>> While going through numutils.c I found the following thing:
>> --- a/src/backend/utils/adt/numutils.c
>> +++ b/src/backend/utils/adt/numutils.c
>> @@ -136,7 +136,7 @@ p
On Wed, Apr 13, 2016 at 3:49 AM, Michael Paquier
wrote:
> Hi all,
>
> While going through numutils.c I found the following thing:
> --- a/src/backend/utils/adt/numutils.c
> +++ b/src/backend/utils/adt/numutils.c
> @@ -136,7 +136,7 @@ pg_ltoa(int32 value, char *a)
> * Avoid problems with the m
Hi all,
While going through numutils.c I found the following thing:
--- a/src/backend/utils/adt/numutils.c
+++ b/src/backend/utils/adt/numutils.c
@@ -136,7 +136,7 @@ pg_ltoa(int32 value, char *a)
* Avoid problems with the most negative integer not being representable
* as a positive inte