[HACKERS] No answers on CommitFest procedures?

2008-07-09 Thread Josh Berkus
Folks, Have received exactly zero feedback on the question of whether I should be assigning reviewers to WIP patches or not. --Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] No answers on CommitFest procedures?

2008-07-09 Thread Pavan Deolasee
On Wed, Jul 9, 2008 at 11:28 PM, Josh Berkus [EMAIL PROTECTED] wrote: Folks, Have received exactly zero feedback on the question of whether I should be assigning reviewers to WIP patches or not. I think we should. For example, one of the WIP patches is submitted by me. One reason I marked it

Re: [HACKERS] No answers on CommitFest procedures?

2008-07-09 Thread Neil Conway
On Wed, 2008-07-09 at 10:58 -0700, Josh Berkus wrote: Have received exactly zero feedback on the question of whether I should be assigning reviewers to WIP patches or not. I suppose it depends on what exactly WIP means, but I should think that if work is still in progress, the patch is not

Re: [HACKERS] No answers on CommitFest procedures?

2008-07-09 Thread Josh Berkus
Pavan, I think we should. For example, one of the WIP patches is submitted by me. One reason I marked it WIP because I was not sure what is considered as WIP and what is not. The patch is ready for review, but of course have some open items and may need further work once I receive the

Re: [HACKERS] No answers on CommitFest procedures?

2008-07-09 Thread Alvaro Herrera
Neil Conway wrote: On Wed, 2008-07-09 at 10:58 -0700, Josh Berkus wrote: Have received exactly zero feedback on the question of whether I should be assigning reviewers to WIP patches or not. I suppose it depends on what exactly WIP means, but I should think that if work is still in

Re: [HACKERS] No answers on CommitFest procedures?

2008-07-09 Thread Neil Conway
On Wed, 2008-07-09 at 14:38 -0400, Alvaro Herrera wrote: But patches in progress still need comments from reviewers. Certainly, but should this be done as part of the commit fest process? Commenting on the future direction that an in-development patch ought to take sounds more like a task for

Re: [HACKERS] No answers on CommitFest procedures?

2008-07-09 Thread Alvaro Herrera
Neil Conway wrote: On Wed, 2008-07-09 at 14:38 -0400, Alvaro Herrera wrote: But patches in progress still need comments from reviewers. Certainly, but should this be done as part of the commit fest process? Commenting on the future direction that an in-development patch ought to take

Re: [HACKERS] No answers on CommitFest procedures?

2008-07-09 Thread Gregory Stark
Neil Conway [EMAIL PROTECTED] writes: On Wed, 2008-07-09 at 14:38 -0400, Alvaro Herrera wrote: But patches in progress still need comments from reviewers. Certainly, but should this be done as part of the commit fest process? Commenting on the future direction that an in-development patch