Re: [HACKERS] Not getting error if ALTER SUBSCRIPTION syntax is wrong.

2017-05-08 Thread Peter Eisentraut
On 5/6/17 08:44, Petr Jelinek wrote: >> We could check validity of the connection string though to complain >> immediately like we do in CREATE. > > The attached does exactly that. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remot

Re: [HACKERS] Not getting error if ALTER SUBSCRIPTION syntax is wrong.

2017-05-07 Thread Noah Misch
On Sat, May 06, 2017 at 02:44:27PM +0200, Petr Jelinek wrote: > On 05/05/17 19:51, Petr Jelinek wrote: > > On 05/05/17 14:40, tushar wrote: > >> Hi, > >> > >> While testing 'logical replication' against v10 , i encountered one > >> issue where data stop migrating after ALTER PUBLICATION. > >> > >>

Re: [HACKERS] Not getting error if ALTER SUBSCRIPTION syntax is wrong.

2017-05-06 Thread Petr Jelinek
On 05/05/17 19:51, Petr Jelinek wrote: > On 05/05/17 14:40, tushar wrote: >> Hi, >> >> While testing 'logical replication' against v10 , i encountered one >> issue where data stop migrating after ALTER PUBLICATION. >> >> X Server >> \\ Make sure wal_level is set to logical in postgresql.conf file >

Re: [HACKERS] Not getting error if ALTER SUBSCRIPTION syntax is wrong.

2017-05-05 Thread Robert Haas
On Fri, May 5, 2017 at 1:51 PM, Petr Jelinek wrote: > Syntax of ALTER command is correct, syntax of the connection string is > not, you are probably getting errors in log from the replication worker. > > We could check validity of the connection string though to complain > immediately like we do i

Re: [HACKERS] Not getting error if ALTER SUBSCRIPTION syntax is wrong.

2017-05-05 Thread Petr Jelinek
On 05/05/17 14:40, tushar wrote: > Hi, > > While testing 'logical replication' against v10 , i encountered one > issue where data stop migrating after ALTER PUBLICATION. > > X Server > \\ Make sure wal_level is set to logical in postgresql.conf file > \\create table/Insert 1 row -> create table t

[HACKERS] Not getting error if ALTER SUBSCRIPTION syntax is wrong.

2017-05-05 Thread tushar
Hi, While testing 'logical replication' against v10 , i encountered one issue where data stop migrating after ALTER PUBLICATION. X Server \\ Make sure wal_level is set to logical in postgresql.conf file \\create table/Insert 1 row -> create table test(n int); insert into t values (1); \\crea