Re: [HACKERS] PATCH: Spinlock Documentation

2015-04-20 Thread Robert Haas
On Sat, Apr 11, 2015 at 12:03 PM, Artem Luzyanin wrote: > Thank you again for your feedback. I have improved the patch with your > suggestions. Please let me know what you think and if I can do anything > else. > > Current CommitFest link for this patch is: > https://commitfest.postgresql.org/5/20

Re: [HACKERS] PATCH: Spinlock Documentation

2015-04-11 Thread Artem Luzyanin
Hello, Thank you again for your feedback. I have improved the patch with your suggestions. Please let me know what you think and if I can do anything else. Current CommitFest link for this patch is:  https://commitfest.postgresql.org/5/208/ Respectfully, Artem Luzyanin On Sunday, April 5,

Re: [HACKERS] PATCH: Spinlock Documentation

2015-04-05 Thread Artem Luzyanin
Hello, Thank you very much for your feedback! I will work on the changes as soon as I can.  Respectfully, Artem Luzyanin On Sunday, April 5, 2015 5:45 PM, Tom Lane wrote: David Fetter writes: > One issue with this patch is that it is not localized.  If someone > goes and changes the

Re: [HACKERS] PATCH: Spinlock Documentation

2015-04-05 Thread Tom Lane
David Fetter writes: > One issue with this patch is that it is not localized. If someone > goes and changes the S_LOCK implementation for one of the platforms > below, or adds a new platform, etc., without changing this comment > too, this comment becomes confusingly obsolete. Indeed. Moreover,

Re: [HACKERS] PATCH: Spinlock Documentation

2015-04-05 Thread David Fetter
On Sun, Apr 05, 2015 at 06:50:59PM +, Artem Luzyanin wrote: > Hello,  > > I am new to PostgreSQLcommunity, but I would like to become a > contributer eventually. I have readthrough your "Submitting Patch" > guide and decided to follow "Start with submitting a patch that is > small anduncontrov

[HACKERS] PATCH: Spinlock Documentation

2015-04-05 Thread Artem Luzyanin
Hello,   I am new to PostgreSQLcommunity, but I would like to become a contributer eventually. I have readthrough your "Submitting Patch" guide and decided to follow "Start with submitting a patch that is small anduncontroversial to help them understand you, and to get you familiar with theover