Re: [HACKERS] PREPARE code notes

2002-09-10 Thread Tom Lane
Karel Zak <[EMAIL PROTECTED]> writes: > On Mon, Sep 09, 2002 at 11:51:08AM -0400, Tom Lane wrote: >>> PostgreSQL executor modify query planns? >> >> Yes, and yes. Unfortunately. > Hmm, it's bad. Is there any way to "fix" executor? It should be fixed IMHO ... but it'll be a major restructuring

Re: [HACKERS] PREPARE code notes

2002-09-10 Thread Karel Zak
On Mon, Sep 09, 2002 at 11:51:08AM -0400, Tom Lane wrote: > Karel Zak <[EMAIL PROTECTED]> writes: > > 1/ ExecuteQuery() (line 110). Why is needful use copyObject()? The > > PostgreSQL executor modify query planns? > > Yes, and yes. Unfortunately. Hmm, it's bad. Is there any way to "fix" e

Re: [HACKERS] PREPARE code notes

2002-09-09 Thread Tom Lane
Karel Zak <[EMAIL PROTECTED]> writes: > 1/ ExecuteQuery() (line 110). Why is needful use copyObject()? The > PostgreSQL executor modify query planns? Yes, and yes. Unfortunately. > 2/ Lines 236 -- 245. Why do you "check for pre-existing entry of > same name" if you create hash table?

[HACKERS] PREPARE code notes

2002-09-09 Thread Karel Zak
Probably nothing important, but I saw it in src/backend/commands/prepare.c: 1/ ExecuteQuery() (line 110). Why is needful use copyObject()? The PostgreSQL executor modify query planns? I think copyObject() is expensive call. 2/ Lines 236 -- 245. Why do you "check for pre-existing ent