David Christensen wrote:
> At this point, I have no real preference for this patch; it is
> just as easy to echo line >> datadir/postgresql.conf, so perhaps
> that makes this patch somewhat pointless.
On reflection, I'm inclined to agree.
> I suppose there's a shaky argument to be made for W
David Christensen escreveu:
> Like I said in the original submission, I found it helpful for the
> programmatic configuration of a number of simultaneous node, but if it's not
> generally useful to the community at large, I'll understand if it's punted.
>
I'm afraid it is the only use case for t
On Jul 23, 2010, at 6:36 AM, Robert Haas wrote:
> 2010/7/23 KaiGai Kohei :
>> Sorry for the confusion.
>>
>> What I wanted to say is the patch itself is fine but we need to make
>> consensus
>> before the detailed code reviewing.
>
> I guess we probably need some more people to express an opin
2010/7/23 KaiGai Kohei :
> Sorry for the confusion.
>
> What I wanted to say is the patch itself is fine but we need to make consensus
> before the detailed code reviewing.
I guess we probably need some more people to express an opinion, then.
Do you have one?
I'm not sure I do, yet. I'd like to
(2010/07/23 13:00), Robert Haas wrote:
> 2010/7/22 KaiGai Kohei:
>> Anyway, it is an obvious feature, and seems to me works fine.
>
> So this makes it sound like you like the feature.
>
>> However, it is not clear for me how do we make progress this feature.
>> If we support a command to include
2010/7/22 KaiGai Kohei :
> Anyway, it is an obvious feature, and seems to me works fine.
So this makes it sound like you like the feature.
> However, it is not clear for me how do we make progress this feature.
> If we support a command to include other configuration, it also needs
> to patch on
David,
I checked your patch. Then, there are a few comments in the code.
Apart from the discussion in this thread, would you fix them please.
| *** a/src/bin/initdb/initdb.c
| --- b/src/bin/initdb/initdb.c
| *** static char infoversion[100];
| *** 111,116
| --- 111,117
| s
On Tue, Jul 20, 2010 at 6:00 PM, Kevin Grittner
wrote:
> What will make everyone happy here?
Nothing.
But on a more serious note, the basic dilemma with this patch is
whether it's useful enough to justify the extra code. I think it's
pretty clearly harmless (modulo the fact that it might have b
(2010/07/21 7:33), Kevin Grittner wrote:
> David Christensen wrote:
>> On Jul 20, 2010, at 5:00 PM, Kevin Grittner wrote:
>
>>> my shop has chosen to never touch the default postgresql.conf
>>> file any more, beyond adding one line to the bottom of it which
>>> is an include directive, to bring i
David Christensen wrote:
> On Jul 20, 2010, at 5:00 PM, Kevin Grittner wrote:
>> my shop has chosen to never touch the default postgresql.conf
>> file any more, beyond adding one line to the bottom of it which
>> is an include directive, to bring in our overrides.
> So you'll now issue:
>
> $
On Jul 20, 2010, at 5:00 PM, Kevin Grittner wrote:
> Top posting. On purpose. :p
>
> This patch seems to be foundering in a sea of opinions. It seems
> that everybody wants to do *something* about this, but what?
>
> For one more opinion, my shop has chosen to never touch the default
> postg
Top posting. On purpose. :p
This patch seems to be foundering in a sea of opinions. It seems
that everybody wants to do *something* about this, but what?
For one more opinion, my shop has chosen to never touch the default
postgresql.conf file any more, beyond adding one line to the bottom
of
David,
I'd like to volunteer reviewing your patch at first in this commit fest.
We already had a few comments on the list before. I want to see your
opinion for the suggestions prior to code reviews.
Itagaki-san suggested:
| > Enclosed is a patch to add a -C option to initdb to allow you to easi
I have added this to the 9.1 commit-fest:
https://commitfest.postgresql.org/action/commitfest_view?id=6
---
David Christensen wrote:
> Hackers,
>
> Enclosed is a patch to add a -C option to initdb to allow you to e
On mån, 2010-03-29 at 00:04 -0500, David Christensen wrote:
> Enclosed is a patch to add a -C option to initdb to allow you to easily
> append configuration directives to the generated postgresql.conf file for use
> in programmatic generation.
I like this idea, but please use small -c for consis
David Christensen wrote:
Enclosed is a patch to add a -C option to initdb to allow you to easily append
configuration directives to the generated postgresql.conf file for use in
programmatic generation.
We had a patch not quite make it for 9.0 that switched over the
postgresql.conf file to m
David Christensen wrote:
> Enclosed is a patch to add a -C option to initdb to allow you to easily
> append configuration directives to the generated postgresql.conf file
Why don't you use just "echo 'options' >> $PGDATA/postgresql.conf" ?
Could you explain where the -C options is better than i
Hackers,
Enclosed is a patch to add a -C option to initdb to allow you to easily append
configuration directives to the generated postgresql.conf file for use in
programmatic generation. In my case, I'd been creating multiple db clusters
with a script and would have specific overrides that I n
18 matches
Mail list logo
