Re: [HACKERS] Performance with new nested-xacts code

2004-07-01 Thread Alvaro Herrera
On Thu, Jul 01, 2004 at 09:07:11AM -0400, Alvaro Herrera wrote: > > Were your numbers also taken with --enable-cassert? It might be > > instructive to compare numbers taken without. > > Ah, yes, it was with asserts enabled. I'll try again. With asserts disabled the situations seems reverted:

Re: [HACKERS] Performance with new nested-xacts code

2004-07-01 Thread Alvaro Herrera
On Thu, Jul 01, 2004 at 08:51:59AM -0400, Tom Lane wrote: > The only thing that's occurred to me since last night is that I > simplified the data structures in trigger.c enough to get rid of > a separate memory context for them. That means one less > MemoryContextCreate/Delete per transaction cyc

Re: [HACKERS] Performance with new nested-xacts code

2004-07-01 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Oh, also the inval.c code now is saving a lot of pfrees at each > transaction end. Nope, that's not it; the old code actually did no retail pfree's anyway --- I just diked out what was really dead code. Besides which, pgbench doesn't do any catalog upd

Re: [HACKERS] Performance with new nested-xacts code

2004-07-01 Thread Alvaro Herrera
On Thu, Jul 01, 2004 at 12:21:55AM -0400, Tom Lane wrote: > This brought me up short. I sure as heck do not see anything in that > patch that would represent a performance gain over before, especially > not in the very vanilla-flavor cases exercised by pgbench. Do you see > an explanation? Oh,

Re: [HACKERS] Performance with new nested-xacts code

2004-06-30 Thread Grant Finnemore
Hi Tom, As requested - although the results are all over the place... :-( One interesting factor in these tests is that the max tps without the new code was 74.7, with the new code, 85.8. This is a Sony Laptop, slow IDE disk, Fedora Core 2 [EMAIL PROTECTED] pgsql-HEAD]$ uname -a Linux localhost.loc

Re: [HACKERS] Performance with new nested-xacts code

2004-06-30 Thread Alvaro Herrera
On Thu, Jul 01, 2004 at 12:21:55AM -0400, Tom Lane wrote: > I was all set to launch into a diatribe about the half dozen performance > issues I think we *must* fix in the new nested-transactions code, I completely agree, of course. > This brought me up short. I sure as heck do not see anything i

[HACKERS] Performance with new nested-xacts code

2004-06-30 Thread Tom Lane
I was all set to launch into a diatribe about the half dozen performance issues I think we *must* fix in the new nested-transactions code, and thought I'd back it up by citing some pgbench numbers. So I ran pgbench runs using yesterday's CVS tip and current. I had to fix a small memory leak befor