Re: [HACKERS] Prefix support for synonym dictionary

2009-08-06 Thread Robert Haas
On Thu, Aug 6, 2009 at 12:53 PM, Jeff Davis wrote: > On Thu, 2009-08-06 at 12:19 -0400, Robert Haas wrote: >> Based on these comments, do you want to go ahead and mark this "Ready >> for Committer"? > > Done, thanks Teodor. > > However, on the commitfest page, the patches got updated in the wrong >

Re: [HACKERS] Prefix support for synonym dictionary

2009-08-06 Thread Jeff Davis
On Thu, 2009-08-06 at 12:19 -0400, Robert Haas wrote: > Based on these comments, do you want to go ahead and mark this "Ready > for Committer"? Done, thanks Teodor. However, on the commitfest page, the patches got updated in the wrong places: "prefix support" and "filtering dictionary support" ar

Re: [HACKERS] Prefix support for synonym dictionary

2009-08-06 Thread Robert Haas
2009/8/6 Teodor Sigaev : >> 1. The docs should be clarified a little. For instance, it should have a >> link back to the definition of a prefix search (12.3.2). I included my >> doc suggestions as an attachment. > > Thank you, merged > >> 2. dsynonym_init() uses findwrd() in a slightly confusing (a

Re: [HACKERS] Prefix support for synonym dictionary

2009-08-06 Thread Teodor Sigaev
1. The docs should be clarified a little. For instance, it should have a link back to the definition of a prefix search (12.3.2). I included my doc suggestions as an attachment. Thank you, merged 2. dsynonym_init() uses findwrd() in a slightly confusing (and perhaps fragile) way. After calling

Re: [HACKERS] Prefix support for synonym dictionary

2009-08-05 Thread Jeff Davis
On Wed, 2009-08-05 at 12:34 -0400, Robert Haas wrote: > Oleg, > > Are you planning to update this patch this week? If not I will set it > to "Returned with Feedback". My only comments were related to docs and comments, and I supplied a patch as a suggested fix for the docs. Also, the patch is ve

Re: [HACKERS] Prefix support for synonym dictionary

2009-08-05 Thread Robert Haas
On Sun, Aug 2, 2009 at 3:05 PM, Jeff Davis wrote: > The patch looks good. > > Comments: > > 1. The docs should be clarified a little. For instance, it should have a > link back to the definition of a prefix search (12.3.2). I included my > doc suggestions as an attachment. > > 2. dsynonym_init() us

Re: [HACKERS] Prefix support for synonym dictionary

2009-08-02 Thread Jeff Davis
Hi, The patch looks good. Comments: 1. The docs should be clarified a little. For instance, it should have a link back to the definition of a prefix search (12.3.2). I included my doc suggestions as an attachment. 2. dsynonym_init() uses findwrd() in a slightly confusing (and perhaps fragile) w

[HACKERS] Prefix support for synonym dictionary

2009-07-14 Thread Oleg Bartunov
Hi there, attached is our patch for CVS HEAD, which adds prefix support for synonym dictionary. Quick example: cat $SHAREDIR/tsearch_data/synonym_sample.syn postgrespgsql postgresql pgsql postgre pgsql gogle googl indices index* =# create text search dictionary syn( template