Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-10 Thread Robert Haas
On Wed, Feb 8, 2017 at 5:31 PM, Jim Nasby wrote: > 11 There existed a race condition /where/ if CREATE INDEX CONCURRENTLY was > called on a column that had not been indexed before, then rows that were > updated by transactions running at the same time as the CREATE

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Jim Nasby
On 2/7/17 9:37 AM, Jonathan S. Katz wrote: Below is the draft of the press release for the update this Thursday: Thanks for the work on this! 11 There existed a race condition if CREATE INDEX CONCURRENTLY was called on a column that had not been indexed before, then rows that were updated

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Jim Nasby
On 2/8/17 2:51 PM, Alvaro Herrera wrote: I always have a bit of mixed feelings with these kind of string manipulations on dynamic SQL. It may look a bit nasty, but locking tables for long periods (or being without an important index for a period) is much worse in production scenarios. I think

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Alvaro Herrera
Tobias Bussmann wrote: > But I could put this > snippet as a "REINDEX CONCURRENTLY" workaround into the Administrative > Snippets category of the wiki, if there are no further objections > about the way it works. Sounds like a good idea. There are further complications: * you can't DROP

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Tobias Bussmann
Am 08.02.2017 um 20:17 schrieb Alvaro Herrera : > Note that this is likely to fail if the original index name is close to > the 63 chars limit. Perhaps it's enough to add substring() when > computing index_name_tmp. (You could just not use :'index_name' there > and rely

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Alvaro Herrera
Tobias Bussmann wrote: > Am 07.02.2017 um 18:44 schrieb Alvaro Herrera : > > 80 CREATE INDEX CONCURRENTLY bad_index_name ON table_name > > (column_name); /* replace names with your original index definition */ > > I was thinking if we could replace that "replace

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Tobias Bussmann
Am 07.02.2017 um 18:44 schrieb Alvaro Herrera : > 80 CREATE INDEX CONCURRENTLY bad_index_name ON table_name (column_name); > /* replace names with your original index definition */ I was thinking if we could replace that "replace names with your original index

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 6:40 PM, Alvaro Herrera wrote: > > Jonathan S. Katz wrote: >> >>> On Feb 7, 2017, at 4:07 PM, Alvaro Herrera wrote: >>> >>> Jonathan S. Katz wrote: >>> Thanks for the clarification. I have updated the recipe

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Alvaro Herrera
Jonathan S. Katz wrote: > > > On Feb 7, 2017, at 4:07 PM, Alvaro Herrera wrote: > > > > Jonathan S. Katz wrote: > > > >> Thanks for the clarification. I have updated the recipe along with Emre’s > >> comments here: > >> > >> [updated text not included in the email]

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 4:39 PM, Michael Banck wrote: > > Hi, > > Am Dienstag, den 07.02.2017, 15:58 -0500 schrieb Jonathan S. Katz: > > >>

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 4:07 PM, Alvaro Herrera wrote: > > Jonathan S. Katz wrote: > >> Thanks for the clarification. I have updated the recipe along with Emre’s >> comments here: >> >> [updated text not included in the email] > > I still don't think the recipe is a

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Michael Banck
Hi, Am Dienstag, den 07.02.2017, 15:58 -0500 schrieb Jonathan S. Katz: > https://git.postgresql.org/gitweb/?p=press.git;a=blob;f=update_releases/current/20170209updaterelease.txt;h=f90d4716f240dbea4cca647b099f79865545b633;hb=d85498c284275bcab4752b91476834de780648b8 It says "[...]then rows that

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Alvaro Herrera
Jonathan S. Katz wrote: > Thanks for the clarification. I have updated the recipe along with Emre’s > comments here: > > [updated text not included in the email] I still don't think the recipe is a very good one because it leaves you with a window where the affected columns are not indexed at

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 12:44 PM, Alvaro Herrera wrote: > > Jonathan S. Katz wrote: > >> Below is the draft of the press release for the update this Thursday: >> >>

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 11:25 AM, Emre Hasegeli wrote: > >> As there are a lot of updates I did my best to consolidate some of the >> bullet points and as usual, people are directed to the release notes. >> Please let me know if there are any inaccuracies so I can fix them ASAP.

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Alvaro Herrera
Jonathan S. Katz wrote: > Below is the draft of the press release for the update this Thursday: > > https://git.postgresql.org/gitweb/?p=press.git;a=blob;f=update_releases/current/20170209updaterelease.md;h=0cccb8986c08527f65f13d704a78c36bb8de7fef;hb=afc01091dea8a1597e8e21430edc3908c581ce0c >

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Alvaro Herrera
Michael Banck wrote: > Hi, > > Am Dienstag, den 07.02.2017, 10:37 -0500 schrieb Jonathan S. Katz: > > > Below is the draft of the press release for the update this Thursday: > > About the CREATE INDEX CONCURRENTLY issue, I wonder whether Peter's > amcheck extension[1] would catch that (for

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Michael Banck
Hi, Am Dienstag, den 07.02.2017, 10:37 -0500 schrieb Jonathan S. Katz: > Below is the draft of the press release for the update this Thursday: About the CREATE INDEX CONCURRENTLY issue, I wonder whether Peter's amcheck extension[1] would catch that (for B-Tree indexes at least), and if that is

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Emre Hasegeli
> As there are a lot of updates I did my best to consolidate some of the > bullet points and as usual, people are directed to the release notes. > Please let me know if there are any inaccuracies so I can fix them ASAP. Just some minor points: > * Several fixes for PostgreSQL operating in hot

[HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
Hi! Below is the draft of the press release for the update this Thursday: https://git.postgresql.org/gitweb/?p=press.git;a=blob;f=update_releases/current/20170209updaterelease.md;h=0cccb8986c08527f65f13d704a78c36bb8de7fef;hb=afc01091dea8a1597e8e21430edc3908c581ce0c