Re: [HACKERS] RFD: Discarded tuple count for SeqScan nodes in EXPLAIN ANALYZE

2009-05-22 Thread Andres Freund
Hi, On 05/22/2009 05:54 PM, Tom Lane wrote: This sort of ties into the discussions we have periodically about allowing EXPLAIN to output XML or some other more-machine-friendly data format. The barrier for adding additional output fields would be a lot lower in such a format. So the best thing

Re: [HACKERS] RFD: Discarded tuple count for SeqScan nodes in EXPLAIN ANALYZE

2009-05-22 Thread Greg Stark
On Fri, May 22, 2009 at 4:54 PM, Tom Lane wrote: > > It doesn't really seem useful enough to justify breaking client-side > code that looks at EXPLAIN output. Fwiw at least pgadmin I don't think would be confused by this. These tool authors aren't enamoured of fragile assumptions and the maintena

Re: [HACKERS] RFD: Discarded tuple count for SeqScan nodes in EXPLAIN ANALYZE

2009-05-22 Thread Tom Lane
Andres Freund writes: > On 05/22/2009 03:42 PM, Heikki Linnakangas wrote: >> Isn't the discarded count always equal to (# of rows in table - matched >> tuples)? Seems pretty redundant to me. > Not for EXISTS(), LIMIT and similar. It doesn't really seem useful enough to justify breaking client-si

Re: [HACKERS] RFD: Discarded tuple count for SeqScan nodes in EXPLAIN ANALYZE

2009-05-22 Thread Andres Freund
Hi, On 05/22/2009 03:42 PM, Heikki Linnakangas wrote: Andres Freund wrote: When analyzing the plan of a query I often find myself questioning whether an additional index may be sensible, or if it is sensible that a SeqScan is used if an index is available. The current EXPLAIN ANALYZE only show

Re: [HACKERS] RFD: Discarded tuple count for SeqScan nodes in EXPLAIN ANALYZE

2009-05-22 Thread Heikki Linnakangas
Andres Freund wrote: When analyzing the plan of a query I often find myself questioning whether an additional index may be sensible, or if it is sensible that a SeqScan is used if an index is available. The current EXPLAIN ANALYZE only shows the number of tuples matching the qualifier of an

Re: [HACKERS] RFD: Discarded tuple count for SeqScan nodes in EXPLAIN ANALYZE - Patch v1

2009-05-22 Thread Andres Freund
... >From 4865950d8bb66ee29cead3ecb17b07812677bfdf Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Fri, 22 May 2009 15:37:13 +0200 Subject: [PATCH] Feature: discarded tuple count display in EXPLAIN ANALYZE --- src/backend/commands/explain.c|5 +++-- src/backend/executor/execScan.c

[HACKERS] RFD: Discarded tuple count for SeqScan nodes in EXPLAIN ANALYZE

2009-05-22 Thread Andres Freund
Hi, When analyzing the plan of a query I often find myself questioning whether an additional index may be sensible, or if it is sensible that a SeqScan is used if an index is available. The current EXPLAIN ANALYZE only shows the number of tuples matching the qualifier of an SeqScan Node - fo