[HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Simon Riggs
On Tue, 2011-01-18 at 19:04 +, Magnus Hagander wrote: Log replication connections only when log_connections is on Previously we'd always log replication connections, with no way to turn them off. You noted that the code was there intentionally, yet you also couldn't see the reason. That

[HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Magnus Hagander
On Wed, Jan 19, 2011 at 13:36, Simon Riggs si...@2ndquadrant.com wrote: On Tue, 2011-01-18 at 19:04 +, Magnus Hagander wrote: Log replication connections only when log_connections is on Previously we'd always log replication connections, with no way to turn them off. You noted that the

[HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Simon Riggs
On Wed, 2011-01-19 at 13:44 +0100, Magnus Hagander wrote: On Wed, Jan 19, 2011 at 13:36, Simon Riggs si...@2ndquadrant.com wrote: On Tue, 2011-01-18 at 19:04 +, Magnus Hagander wrote: Log replication connections only when log_connections is on Previously we'd always log replication

[HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Simon Riggs
On Wed, 2011-01-19 at 12:55 +, Simon Riggs wrote: How will we diagnose erratic connection problems now? The point here is that your effort to *remove* pointless log lines now means that we cannot diagnose production problems with replication unless we now *add* hundreds of pointless log

Re: [HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Robert Haas
On Wed, Jan 19, 2011 at 7:55 AM, Simon Riggs si...@2ndquadrant.com wrote: How will we diagnose erratic connection problems now? As Heikki pointed out, the slave still logs this information, so we can look there. If that's enough, yeah, you'll have to turn log_connections on on the master, but I

Re: [HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Simon Riggs
On Wed, 2011-01-19 at 09:08 -0500, Robert Haas wrote: On Wed, Jan 19, 2011 at 7:55 AM, Simon Riggs si...@2ndquadrant.com wrote: How will we diagnose erratic connection problems now? As Heikki pointed out, the slave still logs this information, so we can look there. If that's enough, yeah,

Re: [HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Florian Pflug
On Jan19, 2011, at 16:16 , Simon Riggs wrote: On Wed, 2011-01-19 at 09:08 -0500, Robert Haas wrote: On Wed, Jan 19, 2011 at 7:55 AM, Simon Riggs si...@2ndquadrant.com wrote: How will we diagnose erratic connection problems now? As Heikki pointed out, the slave still logs this information, so

Re: [HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: So now we have to check *all* of the standby logs in order to check that replication on the master is working without problems. There will be no default capability to tie up events on the master with failures of replication. Events occurring on

Re: [HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Simon Riggs
On Wed, 2011-01-19 at 16:42 +0100, Florian Pflug wrote: Could you explain the failure condition you do have in mind where logging replication connections unconditionally is beneficial? Sure. Replication drops and immediately reconnects during night. When did that happen? How many times did

Re: [HACKERS] Re: [COMMITTERS] pgsql: Log replication connections only when log_connections is on

2011-01-19 Thread Robert Haas
On Wed, Jan 19, 2011 at 11:05 AM, Simon Riggs si...@2ndquadrant.com wrote: The question we should have asked is Why is removing those log entries helpful?. I shouldn't have to justify putting something back, when the good reason for its existence was previously explained and there was no