Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-16 Thread Heikki Linnakangas
Fujii Masao wrote: One problem of the patch is that even if the content of error message is different from the past, it would be skipped when the location of invalid record is the same of the past. For example, if there is a partially-filled unbroken WAL file in the standby, the following

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-16 Thread Heikki Linnakangas
Robert Haas wrote: On Tue, Apr 13, 2010 at 11:49 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: We have the emode_for_corrupt_record() function that's used in all the errors that indicate a corrupt WAL record, that's a perfect place to hook this into. See attached patch.

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-14 Thread Fujii Masao
On Wed, Apr 14, 2010 at 12:49 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: We have the emode_for_corrupt_record() function that's used in all the errors that indicate a corrupt WAL record, that's a perfect place to hook this into. See attached patch. One problem of the

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-13 Thread Heikki Linnakangas
Robert Haas wrote: On Tue, Apr 6, 2010 at 10:36 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Robert Haas wrote: * If standby_mode is enabled, and neither primary_conninfo nor restore_command are set, the standby would get stuck. It's not really stuck, it will replay

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-13 Thread Robert Haas
On Tue, Apr 13, 2010 at 11:49 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Robert Haas wrote: On Tue, Apr 6, 2010 at 10:36 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Robert Haas wrote:     * If standby_mode is enabled, and neither primary_conninfo

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-09 Thread Fujii Masao
On Thu, Apr 8, 2010 at 11:00 PM, Robert Haas robertmh...@gmail.com wrote: I think you could shut it down at the first point at which it is holding no locks, rather than letting it continue recovering and potentially retake some new locks.  That would be more consistent with the general idea of

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-08 Thread Fujii Masao
On Thu, Apr 8, 2010 at 10:41 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Apr 7, 2010 at 8:17 AM, Simon Riggs si...@2ndquadrant.com wrote: OK, that looks a lot less risky than I had understood from discussions. The main thing for me is it doesn't interfere with Startup or WalReceiver,

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-08 Thread Robert Haas
On Thu, Apr 8, 2010 at 2:54 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Apr 8, 2010 at 10:41 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Apr 7, 2010 at 8:17 AM, Simon Riggs si...@2ndquadrant.com wrote: OK, that looks a lot less risky than I had understood from discussions.

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-08 Thread Simon Riggs
On Thu, 2010-04-08 at 06:58 -0400, Robert Haas wrote: Thanks. Committed. Thanks. The following TODO item should be removed? Redefine smart shutdown in standby mode to exist as soon as all read-only connections are gone. http://wiki.postgresql.org/wiki/Todo#Standby_server_mode Or

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-08 Thread Robert Haas
On Thu, Apr 8, 2010 at 7:37 AM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-04-08 at 06:58 -0400, Robert Haas wrote: Thanks.  Committed. Thanks. The following TODO item should be removed? Redefine smart shutdown in standby mode to exist as soon as all read-only connections

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-08 Thread Simon Riggs
On Thu, 2010-04-08 at 07:53 -0400, Robert Haas wrote: I do. I see no reason to do the latter, ever, so should not be added to any TODO. Well, stopping recovery earlier would mean fewer locks, which would mean a better chance for the read-only backends to finish their work and exit

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-08 Thread Robert Haas
On Thu, Apr 8, 2010 at 8:00 AM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-04-08 at 07:53 -0400, Robert Haas wrote: I do. I see no reason to do the latter, ever, so should not be added to any TODO. Well, stopping recovery earlier would mean fewer locks, which would mean a

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-08 Thread Simon Riggs
On Thu, 2010-04-08 at 09:40 -0400, Robert Haas wrote: On Thu, Apr 8, 2010 at 8:00 AM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-04-08 at 07:53 -0400, Robert Haas wrote: I do. I see no reason to do the latter, ever, so should not be added to any TODO. Well, stopping

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-08 Thread Robert Haas
On Thu, Apr 8, 2010 at 9:56 AM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-04-08 at 09:40 -0400, Robert Haas wrote: On Thu, Apr 8, 2010 at 8:00 AM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-04-08 at 07:53 -0400, Robert Haas wrote: I do. I see no reason to do the

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-07 Thread Robert Haas
On Tue, Apr 6, 2010 at 3:14 PM, Simon Riggs si...@2ndquadrant.com wrote: On Tue, 2010-04-06 at 11:06 -0400, Robert Haas wrote:     * Redefine smart shutdown in standby mode? Drop. Too big a change at this point. We have a working patch for this - I want to commit it.  I don't think

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-07 Thread Simon Riggs
On Wed, 2010-04-07 at 07:40 -0400, Robert Haas wrote: On Tue, Apr 6, 2010 at 3:14 PM, Simon Riggs si...@2ndquadrant.com wrote: On Tue, 2010-04-06 at 11:06 -0400, Robert Haas wrote: * Redefine smart shutdown in standby mode? Drop. Too big a change at this point. We have a

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-07 Thread Robert Haas
On Wed, Apr 7, 2010 at 8:17 AM, Simon Riggs si...@2ndquadrant.com wrote: OK, that looks a lot less risky than I had understood from discussions. The main thing for me is it doesn't interfere with Startup or WalReceiver, so assuming it works I've got no objections. Thanks for chasing this down,

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-07 Thread Robert Haas
On Tue, Apr 6, 2010 at 4:09 PM, Simon Riggs si...@2ndquadrant.com wrote: On Tue, 2010-04-06 at 10:09 +0300, Heikki Linnakangas wrote:     *  Walsender and dblink are not interruptible on win32. - related thread I'd actually be happy to just leave it for 9.0, but it seems like consensus

[HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Heikki Linnakangas
I triaged the list of open items on the Streaming Replication wiki page. I propose that we drop the ones I've marked as Drop below, and move the remaining items to the main Open Items page for better visibility. And of course try to resolve them as quickly as possible. * Walsender and

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Fujii Masao
On Tue, Apr 6, 2010 at 4:09 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I triaged the list of open items on the Streaming Replication wiki page. I propose that we drop the ones I've marked as Drop below, and move the remaining items to the main Open Items page for better

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Robert Haas
I wrote my previous email before reading this. On Tue, Apr 6, 2010 at 3:09 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I triaged the list of open items on the Streaming Replication wiki page. I propose that we drop the ones I've marked as Drop below, and move the

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Heikki Linnakangas
Robert Haas wrote: On Tue, Apr 6, 2010 at 3:09 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: * Add the GUC parameter to specify the maximum number of log file segments held in pg_xlog directory to send to the standby server. Which is useful to avoid disk full in the

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Robert Haas
On Tue, Apr 6, 2010 at 10:36 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Robert Haas wrote: On Tue, Apr 6, 2010 at 3:09 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote:     * Add the GUC parameter to specify the maximum number of log file segments held

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: I triaged the list of open items on the Streaming Replication wiki page. I propose that we drop the ones I've marked as Drop below, and move the remaining items to the main Open Items page for better visibility. By drop do you mean

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Tue, Apr 6, 2010 at 4:09 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote:     * Fix things so that any such variables inherited from the server environment are intentionally *NOT* used for making SR connections. Drop. Besides,

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: I triaged the list of open items on the Streaming Replication wiki page. I propose that we drop the ones I've marked as Drop below, and move the remaining items to the main Open Items page for better visibility.

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Erik Rijkers
On Tue, April 6, 2010 19:29, Heikki Linnakangas wrote: [...] I've added the ones that should be addressed in the future to the TODO list. I added a new subsection for standby server and streaming replication related items: http://wiki.postgresql.org/wiki/Todo#Standby_server_mode I reported

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Simon Riggs
On Tue, 2010-04-06 at 20:27 +0200, Erik Rijkers wrote: Was the issue eventually found/solved? We think so, but the event was not conclusively traceable. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Simon Riggs
On Tue, 2010-04-06 at 11:06 -0400, Robert Haas wrote: * Redefine smart shutdown in standby mode? Drop. Too big a change at this point. We have a working patch for this - I want to commit it. I don't think it's a big change, and the current behavior is extremely pathological.

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-06 Thread Simon Riggs
On Tue, 2010-04-06 at 10:09 +0300, Heikki Linnakangas wrote: * Walsender and dblink are not interruptible on win32. - related thread I'd actually be happy to just leave it for 9.0, but it seems like consensus has been reached on how to fix it, and Fujii is working on a patch, so let's