Re: [HACKERS] Should we automatically run duplicate_oids?

2013-08-02 Thread Atri Sharma
Sent from my iPad On 02-Aug-2013, at 10:30, Bruce Momjian br...@momjian.us wrote: On Mon, Jul 8, 2013 at 06:25:44PM -0700, Peter Geoghegan wrote: When rebasing a patch that I'm working on, I occasionally forget to update the oid of any pg_proc.h entries I may have created. Of course this

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-08-01 Thread Bruce Momjian
On Mon, Jul 8, 2013 at 06:25:44PM -0700, Peter Geoghegan wrote: When rebasing a patch that I'm working on, I occasionally forget to update the oid of any pg_proc.h entries I may have created. Of course this isn't a real problem; when I go to initdb, I immediately recognize what has happened.

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-09 Thread Andrew Dunstan
On 07/08/2013 11:03 PM, Peter Geoghegan wrote: On Mon, Jul 8, 2013 at 7:59 PM, Peter Eisentraut pete...@gmx.net wrote: I don't think rewriting it in Perl is necessary or even desirable. I don't see anything particularly unportable in that script as it is. I was under the impression that the

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-09 Thread Andrew Dunstan
On 07/09/2013 10:40 AM, Andrew Dunstan wrote: On 07/08/2013 11:03 PM, Peter Geoghegan wrote: On Mon, Jul 8, 2013 at 7:59 PM, Peter Eisentraut pete...@gmx.net wrote: I don't think rewriting it in Perl is necessary or even desirable. I don't see anything particularly unportable in that script

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-09 Thread Peter Eisentraut
On 7/9/13 10:40 AM, Andrew Dunstan wrote: This is actually a pretty trivial task. Here is a simple perl version: But that would make Perl a hard build requirement. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-09 Thread Andrew Dunstan
On 07/09/2013 01:55 PM, Peter Eisentraut wrote: On 7/9/13 10:40 AM, Andrew Dunstan wrote: This is actually a pretty trivial task. Here is a simple perl version: But that would make Perl a hard build requirement. Well, it already is unless you're not building from git AND you're not

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-09 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On 7/9/13 10:40 AM, Andrew Dunstan wrote: This is actually a pretty trivial task. Here is a simple perl version: But that would make Perl a hard build requirement. My opinion is that this script should only run if you've changed some catalog .h files.

[HACKERS] Should we automatically run duplicate_oids?

2013-07-08 Thread Peter Geoghegan
When rebasing a patch that I'm working on, I occasionally forget to update the oid of any pg_proc.h entries I may have created. Of course this isn't a real problem; when I go to initdb, I immediately recognize what has happened. All the same, it seems like there is a case to be made for having

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-08 Thread Tom Lane
Peter Geoghegan p...@heroku.com writes: ... All the same, it seems like there is a case to be made for having this run automatically at build time, and having the build fail on the basis of there being a duplicate This would require a rather higher standard of portability than duplicate_oids

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-08 Thread Peter Geoghegan
On Mon, Jul 8, 2013 at 6:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: This would require a rather higher standard of portability than duplicate_oids has heretofore been held to. Ah, yes. I suppose that making this happen would necessitate rewriting the script in highly portable Perl.

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-08 Thread Peter Eisentraut
On Mon, 2013-07-08 at 19:38 -0700, Peter Geoghegan wrote: On Mon, Jul 8, 2013 at 6:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: This would require a rather higher standard of portability than duplicate_oids has heretofore been held to. Ah, yes. I suppose that making this happen would

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-08 Thread Peter Geoghegan
On Mon, Jul 8, 2013 at 7:59 PM, Peter Eisentraut pete...@gmx.net wrote: I don't think rewriting it in Perl is necessary or even desirable. I don't see anything particularly unportable in that script as it is. I was under the impression that the final patch ought to work on Windows too.

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-08 Thread Craig Ringer
On 07/09/2013 11:03 AM, Peter Geoghegan wrote: On Mon, Jul 8, 2013 at 7:59 PM, Peter Eisentraut pete...@gmx.net wrote: I don't think rewriting it in Perl is necessary or even desirable. I don't see anything particularly unportable in that script as it is. I was under the impression that the

Re: [HACKERS] Should we automatically run duplicate_oids?

2013-07-08 Thread Atri Sharma
On Tue, Jul 9, 2013 at 6:55 AM, Peter Geoghegan p...@heroku.com wrote: When rebasing a patch that I'm working on, I occasionally forget to update the oid of any pg_proc.h entries I may have created. Of course this isn't a real problem; when I go to initdb, I immediately recognize what has