On Tue, Nov 8, 2016 at 1:28 PM, David Steele wrote:
> Hi Magnus,
>
> On 11/7/16 2:07 PM, Magnus Hagander wrote:
>
>> On Sat, Oct 29, 2016 at 4:12 PM, Michael Paquier
>> Indeed, giving the attached for REL9_6_STABLE. You could as well have
>> a test for pg_stat_tmp but honestly that's not
Hi Magnus,
On 11/7/16 2:07 PM, Magnus Hagander wrote:
On Sat, Oct 29, 2016 at 4:12 PM, Michael Paquier
Indeed, giving the attached for REL9_6_STABLE. You could as well have
a test for pg_stat_tmp but honestly that's not worth it. One thing I
have noticed is that the patch does not us
On Sat, Oct 29, 2016 at 4:12 PM, Michael Paquier
wrote:
> On Fri, Oct 28, 2016 at 9:57 PM, David Steele wrote:
> > On 10/28/16 3:49 PM, Magnus Hagander wrote:
> > The change from 10 to 11 increases the tests that are skipped on Windows,
> > which is necessary because one extra symlink test is ad
On Fri, Oct 28, 2016 at 9:57 PM, David Steele wrote:
> On 10/28/16 3:49 PM, Magnus Hagander wrote:
> The change from 10 to 11 increases the tests that are skipped on Windows,
> which is necessary because one extra symlink test is added.
>
> I think you need:
>
> [...]
>
> The rest of the tests are
On 10/28/16 3:49 PM, Magnus Hagander wrote:
On Fri, Oct 28, 2016 at 2:44 PM, David Steele mailto:da...@pgmasters.net>> wrote:
The patch looks sane to me, but I think it would be good to
backpatch the TAP test from the exclusion patch that tests
pg_replslot as a symlink.
So that's the
On Fri, Oct 28, 2016 at 2:44 PM, David Steele wrote:
> On 10/28/16 11:53 AM, Magnus Hagander wrote:
>
>> In 9.6 and earlier, if you change pg_stat_tmp to be a symlink,
>> basebackups no longer work. That's because we create symlink entry in
>> the tarfile for it instead of an empty directory, but
On 10/28/16 11:53 AM, Magnus Hagander wrote:
In 9.6 and earlier, if you change pg_stat_tmp to be a symlink,
basebackups no longer work. That's because we create symlink entry in
the tarfile for it instead of an empty directory, but with no data,
which Breaks Everything (TM).
This was fixed in he
In 9.6 and earlier, if you change pg_stat_tmp to be a symlink, basebackups
no longer work. That's because we create symlink entry in the tarfile for
it instead of an empty directory, but with no data, which Breaks Everything
(TM).
This was fixed in head in 6ad8ac60, which introduced "more excludes