Re: [HACKERS] The pgrminclude problem

2012-08-20 Thread Robert Haas
On Mon, Aug 20, 2012 at 12:03 PM, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of lun ago 20 11:43:44 -0400 2012: >> I actually think we'd probably be better off running pgrminclude once >> per release cycle rather than any less often. When the number of >> changes gets into the hu

Re: [HACKERS] The pgrminclude problem

2012-08-20 Thread Tom Lane
Robert Haas writes: > On Thu, Aug 16, 2012 at 12:17 PM, Peter Geoghegan > wrote: >> Yeah. Even if this could be made to work well, we'd still have to do >> something like get an absolute consensus from all build farm animals, >> if we expected to have an absolutely trustworthy list. I don't thin

Re: [HACKERS] The pgrminclude problem

2012-08-20 Thread Alvaro Herrera
Excerpts from Robert Haas's message of lun ago 20 11:43:44 -0400 2012: > I actually think we'd probably be better off running pgrminclude once > per release cycle rather than any less often. When the number of > changes gets into the hundreds or thousands of lines it becomes much > more difficult

Re: [HACKERS] The pgrminclude problem

2012-08-20 Thread Robert Haas
On Thu, Aug 16, 2012 at 12:17 PM, Peter Geoghegan wrote: > On 16 August 2012 16:56, Bruce Momjian wrote: >> Good to know. We only use pgrminclude very five years or so, and Tom >> isn't even keen on that. > > Yeah. Even if this could be made to work well, we'd still have to do > something like ge

Re: [HACKERS] The pgrminclude problem

2012-08-16 Thread Peter Geoghegan
On 16 August 2012 16:56, Bruce Momjian wrote: > Good to know. We only use pgrminclude very five years or so, and Tom > isn't even keen on that. Yeah. Even if this could be made to work well, we'd still have to do something like get an absolute consensus from all build farm animals, if we expected

Re: [HACKERS] The pgrminclude problem

2012-08-16 Thread Bruce Momjian
On Thu, Aug 16, 2012 at 04:48:34PM +0100, Peter Geoghegan wrote: > I found a tool that Google authored that attempts to solve the same > problems as pgrminclude does in our codebase. It's called "include > what you use", and is based on Clang. The project is hosted here: > > http://code.google.co

[HACKERS] The pgrminclude problem

2012-08-16 Thread Peter Geoghegan
I found a tool that Google authored that attempts to solve the same problems as pgrminclude does in our codebase. It's called "include what you use", and is based on Clang. The project is hosted here: http://code.google.com/p/include-what-you-use/ I'm not suggesting that we should start using th