On 10/03/16 13:43, Pavan Deolasee wrote:
On Wed, Mar 9, 2016 at 7:56 PM, Petr Jelinek mailto:p...@2ndquadrant.com>> wrote:
Hi,
I wonder why you define the gidlen as uint32 when it would fit into
uint8 which in the current TwoPhaseFileHeader struct should be win
of 8 bytes on pa
On Wed, Mar 9, 2016 at 7:56 PM, Petr Jelinek wrote:
> Hi,
>
> I wonder why you define the gidlen as uint32 when it would fit into uint8
> which in the current TwoPhaseFileHeader struct should be win of 8 bytes on
> padding (on 64bit). I think that's something worth considering given that
> this
Hi,
I wonder why you define the gidlen as uint32 when it would fit into
uint8 which in the current TwoPhaseFileHeader struct should be win of 8
bytes on padding (on 64bit). I think that's something worth considering
given that this patch aims to lower the size of the data.
--
Petr Jelinek
On 03/08/2016 11:54 PM, Pavan Deolasee wrote:
On Fri, Mar 4, 2016 at 9:16 PM, Jesper Pedersen
wrote:
I can confirm the marginal speed up in tps due to the new WAL size.
The TWOPHASE_MAGIC constant should be changed, as the file header has
changed definition, right ?
Thanks for looking at it
On Fri, Mar 4, 2016 at 9:16 PM, Jesper Pedersen
wrote:
>
>>
>>
> I can confirm the marginal speed up in tps due to the new WAL size.
>
> The TWOPHASE_MAGIC constant should be changed, as the file header has
> changed definition, right ?
>
Thanks for looking at it. I've revised the patch by incre
On 02/29/2016 08:45 AM, Pavan Deolasee wrote:
Hello Hackers,
The maximum size of the GID, used as a 2PC identifier is currently defined
as 200 bytes (see src/backend/access/transam/twophase.c). The actual GID
used by the applications though may be much smaller than that. So IMO
instead of WAL lo
Hello Hackers,
The maximum size of the GID, used as a 2PC identifier is currently defined
as 200 bytes (see src/backend/access/transam/twophase.c). The actual GID
used by the applications though may be much smaller than that. So IMO
instead of WAL logging the entire 200 bytes during PREPARE TRANSA