Re: [HACKERS] WIP patch for system-catalog vacuuming via a relation map

2010-02-06 Thread Heikki Linnakangas
Tom Lane wrote: > Josh Berkus writes: >>> Barring objections I'm going to press ahead with completing and >>> committing this; then in a separate patch remove VACUUM FULL INPLACE. > >> Was it our determination that we could remove VFI if we eliminated the >> system catalogs? I'm fine with it, I

Re: [HACKERS] WIP patch for system-catalog vacuuming via a relation map

2010-02-05 Thread Tom Lane
Heikki Linnakangas writes: > Tom Lane wrote: >> I thought the consensus was to remove it if possible. There may still >> be some "marginal" use cases, but they don't justify the work that'd >> be needed to make it play safely with HS; let alone fixing the other >> longstanding gotchas with it, li

Re: [HACKERS] WIP patch for system-catalog vacuuming via a relation map

2010-02-05 Thread Bruce Momjian
Tom Lane wrote: > Josh Berkus writes: > >> Barring objections I'm going to press ahead with completing and > >> committing this; then in a separate patch remove VACUUM FULL INPLACE. > > > Was it our determination that we could remove VFI if we eliminated the > > system catalogs? I'm fine with it

Re: [HACKERS] WIP patch for system-catalog vacuuming via a relation map

2010-02-05 Thread Tom Lane
Josh Berkus writes: >> Barring objections I'm going to press ahead with completing and >> committing this; then in a separate patch remove VACUUM FULL INPLACE. > Was it our determination that we could remove VFI if we eliminated the > system catalogs? I'm fine with it, I just thought some people

Re: [HACKERS] WIP patch for system-catalog vacuuming via a relation map

2010-02-05 Thread Josh Berkus
> Barring objections I'm going to press ahead with completing and > committing this; then in a separate patch remove VACUUM FULL INPLACE. Was it our determination that we could remove VFI if we eliminated the system catalogs? I'm fine with it, I just thought some people had a marginal use case f

Re: [HACKERS] WIP patch for system-catalog vacuuming via a relation map

2010-02-05 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Barring objections I'm going to press ahead with completing and >> committing this; then in a separate patch remove VACUUM FULL INPLACE. > With the second patch, we will continue to support reading > XVAC_MOVED_OUT and IN hint bits, but never set them,

Re: [HACKERS] WIP patch for system-catalog vacuuming via a relation map

2010-02-05 Thread Alvaro Herrera
Tom Lane wrote: > Barring objections I'm going to press ahead with completing and > committing this; then in a separate patch remove VACUUM FULL INPLACE. With the second patch, we will continue to support reading XVAC_MOVED_OUT and IN hint bits, but never set them, correct? -- Alvaro Herrera

[HACKERS] WIP patch for system-catalog vacuuming via a relation map

2010-02-05 Thread Tom Lane
Attached is the current state of my work on letting system catalogs be processed by new-style VACUUM FULL (a/k/a CLUSTER). I haven't done the WAL support nor worried about interlocking concurrent updates of relation map files, but it passes the regression tests and can do VACUUM FULL of every syst