Re: [HACKERS] add more NLS to bin

2016-11-07 Thread Michael Paquier
On Tue, Nov 8, 2016 at 12:13 AM, Peter Eisentraut wrote: > On 11/5/16 8:03 AM, Michael Paquier wrote: >> On Sat, Nov 5, 2016 at 9:17 AM, Peter Eisentraut >> wrote: >>> > On 11/3/16 7:17 PM, Michael Paquier wrote: >> This patch not being complicated, so I would vote for those being >> ad

Re: [HACKERS] add more NLS to bin

2016-11-07 Thread Peter Eisentraut
On 11/5/16 8:03 AM, Michael Paquier wrote: > On Sat, Nov 5, 2016 at 9:17 AM, Peter Eisentraut > wrote: >> > On 11/3/16 7:17 PM, Michael Paquier wrote: >>> >> This patch not being complicated, so I would vote for those being >>> >> addressed now so as they are not forgotten even if there is a FIXME

Re: [HACKERS] add more NLS to bin

2016-11-07 Thread Peter Eisentraut
On 11/5/16 8:03 AM, Michael Paquier wrote: >> > Yeah that was wrong anyway. The previously existing translation markers >> > were wrong. We want to translate the fmt, not the formatted message. > Does using one way or the other actually change something? Because > pg_rewind/logging.c is not marki

Re: [HACKERS] add more NLS to bin

2016-11-05 Thread Michael Paquier
On Sat, Nov 5, 2016 at 9:17 AM, Peter Eisentraut wrote: > On 11/3/16 7:17 PM, Michael Paquier wrote: >> This patch not being complicated, so I would vote for those being >> addressed now so as they are not forgotten even if there is a FIXME >> flag added. Perhaps you don't think so, and as that's

Re: [HACKERS] add more NLS to bin

2016-11-04 Thread Peter Eisentraut
On 11/3/16 7:17 PM, Michael Paquier wrote: > This patch not being complicated, so I would vote for those being > addressed now so as they are not forgotten even if there is a FIXME > flag added. Perhaps you don't think so, and as that's a minor issue > I'll be fine with your judgement as well. OK,

Re: [HACKERS] add more NLS to bin

2016-11-03 Thread Michael Paquier
On Fri, Nov 4, 2016 at 1:44 AM, Peter Eisentraut wrote: > On 10/31/16 1:58 AM, Michael Paquier wrote: >> In info.c, missing some entries in report_unmatched_relation() when >> reporting unmatching relations? > > Yeah, that will need a bit of a rewrite, so FIXME later? This patch not being complic

Re: [HACKERS] add more NLS to bin

2016-11-03 Thread Peter Eisentraut
On 10/31/16 1:58 AM, Michael Paquier wrote: > 2) For 0002 and pg_test_fsync, I am seeing a missing entry: > printf(NA_FORMAT, "n/a*\n"); ok > 4) 0004 and pg_upgrade... In check.c, three places like that: > if (!db_used) > { > fprintf(script, "Databa

Re: [HACKERS] add more NLS to bin

2016-10-30 Thread Michael Paquier
On Thu, Oct 27, 2016 at 10:02 AM, Peter Eisentraut wrote: > Here is a series of patches to add NLS to the remaining bin programs, > which were moved from contrib a while ago. (If you're missing pgbench, > I'm skipping that for now because it's more complicated.) I'll add this > to the commit fes

Re: [HACKERS] add more NLS to bin

2016-10-26 Thread Michael Paquier
On Thu, Oct 27, 2016 at 10:27 AM, Peter Eisentraut wrote: > On 10/26/16 9:18 PM, Michael Paquier wrote: >> Side question just for curiosity: when is AVAIL_LANGUAGES filled? Once >> the translations are added to the tree? > > Yes, that happens when the translations are copied in before a release. >

Re: [HACKERS] add more NLS to bin

2016-10-26 Thread Peter Eisentraut
On 10/26/16 9:18 PM, Michael Paquier wrote: > Side question just for curiosity: when is AVAIL_LANGUAGES filled? Once > the translations are added to the tree? Yes, that happens when the translations are copied in before a release. See here for the script that is normally used: https://git.postgre

Re: [HACKERS] add more NLS to bin

2016-10-26 Thread Michael Paquier
On Thu, Oct 27, 2016 at 10:02 AM, Peter Eisentraut wrote: > Here is a series of patches to add NLS to the remaining bin programs, > which were moved from contrib a while ago. (If you're missing pgbench, > I'm skipping that for now because it's more complicated.) I'll add this > to the commit fes

[HACKERS] add more NLS to bin

2016-10-26 Thread Peter Eisentraut
Here is a series of patches to add NLS to the remaining bin programs, which were moved from contrib a while ago. (If you're missing pgbench, I'm skipping that for now because it's more complicated.) I'll add this to the commit fest. -- Peter Eisentraut http://www.2ndQuadrant.com/ P