Re: [HACKERS] bug in DROP TABLESPACE

2004-07-10 Thread Bruce Momjian
Added to TODO: * Allow changing of already-created database and schema tablespaces --- Christopher Kings-Lynne wrote: > > Tom already mentioned this just after committing tablespaces: 'Minor DROP > > TABLE

Re: [HACKERS] bug in DROP TABLESPACE

2004-07-10 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: > Christopher Kings-Lynne wrote: >> It seems to me that we have mixed up two concepts: the tablespaces >> that a database is IN and the default tablespaces for any schemas >> created in that tablespace. This will probably cause trouble further >> down

Re: [HACKERS] bug in DROP TABLESPACE

2004-07-10 Thread Andreas Pflug
Christopher Kings-Lynne wrote: It seems to me that we have mixed up two concepts: the tablespaces that a database is IN and the default tablespaces for any schemas created in that tablespace. This will probably cause trouble further down the track :( As long as we interpret schema and databa

Re: [HACKERS] bug in DROP TABLESPACE

2004-07-10 Thread Christopher Kings-Lynne
The latter is relatively trivial as long as you interpret it as just changing the default TS for tables created later in that schema. (On the other hand, you can fake that with a simple UPDATE to pg_namespace, so I'm not sure it qualifies as a "must have".) The former is a real mess since it would

Re: [HACKERS] bug in DROP TABLESPACE

2004-07-09 Thread Bruce Momjian
TODO item? --- Tom Lane wrote: > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > > The other thing we need are these two commands: > > > ALTER DATABASE foo SET TABLESPACE spc; > > ALTER SCHEMA foo SET TABLESPACE spc;

Re: [HACKERS] bug in DROP TABLESPACE

2004-07-09 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > The other thing we need are these two commands: > ALTER DATABASE foo SET TABLESPACE spc; > ALTER SCHEMA foo SET TABLESPACE spc; > I think these should not be considered new features but essential > functionality left out of the original patch

Re: [HACKERS] bug in DROP TABLESPACE

2004-07-06 Thread Christopher Kings-Lynne
Tom already mentioned this just after committing tablespaces: 'Minor DROP TABLESPACE issue' http://www.mail-archive.com/[EMAIL PROTECTED]/msg46540.html In fact, I see that you contributed to the thread :-). I think the result of the thread was to make the error message a little more helpful and tha

Re: [HACKERS] bug in DROP TABLESPACE

2004-07-06 Thread Gavin Sherry
On Tue, 6 Jul 2004, Christopher Kings-Lynne wrote: > There is bad breakage in the DROP TABLESPACE command if the only thing > "in" that tablespace is the default tablespaces for a schema: > > test=# create tablespace myspace location '/home/chriskl/loc'; > CREATE TABLESPACE > test=# create schema

[HACKERS] bug in DROP TABLESPACE

2004-07-06 Thread Christopher Kings-Lynne
There is bad breakage in the DROP TABLESPACE command if the only thing "in" that tablespace is the default tablespaces for a schema: test=# create tablespace myspace location '/home/chriskl/loc'; CREATE TABLESPACE test=# create schema myschema tablespace myspace; CREATE SCHEMA test=# drop tablesp