Re: [HACKERS] buildfarm does not test "make check"

2015-08-14 Thread Andrew Dunstan
On 08/14/2015 09:27 AM, Robert Haas wrote: On Thu, Aug 13, 2015 at 2:11 PM, Alvaro Herrera wrote: So I added the brin isolation test back. Because it needs the pageinspect module, it can only work under "make check", not installcheck. The problem is that this means buildfarm will not run it

Re: [HACKERS] buildfarm does not test "make check"

2015-08-14 Thread Robert Haas
On Thu, Aug 13, 2015 at 2:11 PM, Alvaro Herrera wrote: > So I added the brin isolation test back. Because it needs the > pageinspect module, it can only work under "make check", not > installcheck. The problem is that this means buildfarm will not run it, > because it only runs installcheck :-(

Re: [HACKERS] buildfarm does not test "make check"

2015-08-13 Thread Andrew Dunstan
On 08/13/2015 02:52 PM, Alvaro Herrera wrote: You're also going to have to handle the msvc side of things. That won't be trivial. See discussion elsewhere today about how we've got that wrong recently. Oh my. The pg_upgrade code in src/tools/msvc/vcregress.pl looks rather unhealthy, and I don

Re: [HACKERS] buildfarm does not test "make check"

2015-08-13 Thread Alvaro Herrera
Andrew Dunstan wrote: > The buildfarm server doesn't control anything the clients do except it > provides them with a list of branches we are interested in. Even that is > invisible to the main program, and only used by the wrapper run_branches.pl. > The main program can run entirely offline and I

Re: [HACKERS] buildfarm does not test "make check"

2015-08-13 Thread Andrew Dunstan
On 08/13/2015 02:11 PM, Alvaro Herrera wrote: So I added the brin isolation test back. Because it needs the pageinspect module, it can only work under "make check", not installcheck. The problem is that this means buildfarm will not run it, because it only runs installcheck :-( I realized th

[HACKERS] buildfarm does not test "make check"

2015-08-13 Thread Alvaro Herrera
So I added the brin isolation test back. Because it needs the pageinspect module, it can only work under "make check", not installcheck. The problem is that this means buildfarm will not run it, because it only runs installcheck :-( I realized that the important modules that run under "make chec