Re: [HACKERS] changes to support logging

2003-08-14 Thread Andrew Dunstan
I should have said "struct timezone' instead of 'struct tz' (ain't no such animal). But the first argument is a struct timeval *, which has no reference to a timezone. Anyway - pointless to argue - I'll make the changes. NULL should work: the man page says this: If either tv or tz is nul

[HACKERS] changes to support logging

2003-08-14 Thread Andrew Dunstan
To support some of the logging changes I'm working on, I propose to add the following members to struct Port, unless anyone objects - these are all calculated in postmaster/postmaster.c: struct tm session_start; char * remote_host; char * remote_port; Question: In setting these is it better t

Re: [HACKERS] changes to support logging

2003-08-07 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > I've noticed an inconsistency in calls to gettimeofday(): sometimes it > is passed a struct tz (which is ignored) as the second argument, and > sometimes NULL as the second argument. My understanding is that the > second argument is basically useless