Re: [HACKERS] compile errors in new PL/Pler

2004-07-05 Thread Marc G. Fournier
On Fri, 2 Jul 2004, Joshua D. Drake wrote: So we have three choices as I see it: 1) revert the change 2) require some minimally recent version of perl 3) fix the issue in place Preferences? Joshua/Andrew -- do you want to take a shot at making this work on perl 5.00503? I personally don't have

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Andrew Dunstan
Joe Conway said: Marc G. Fournier wrote: On Fri, 2 Jul 2004, Christopher Kings-Lynne wrote: I am going to bet dollars to donuts that it is your perl version. Perl 5.00503 is ancient. Try upgrading to at least 5.6. Not much I can do about that - it's builtin as part of FreeBSD 4.x series.

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Christopher Kings-Lynne
1 is not acceptable, and 2 kinda sucks. Please try adding this to SPI.xs, #ifndef aTHX_ #define aTHX_ #endif recompile and test by calling spi_exec_query with more than 2 arguments like this: Hmmm, compiled fine, but then I get this: -bash-2.05b$ createlang -d test plperl ERROR: could not load

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Andrew Dunstan
Christopher Kings-Lynne said: 1 is not acceptable, and 2 kinda sucks. Please try adding this to SPI.xs, #ifndef aTHX_ #define aTHX_ #endif recompile and test by calling spi_exec_query with more than 2 arguments like this: Hmmm, compiled fine, but then I get this: -bash-2.05b$

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Abhijit Menon-Sen
At 2004-07-02 08:55:56 -0400, [EMAIL PROTECTED] wrote: In the meantime, does this solve your problem?: #ifndef eval_pv #define eval_pv perl_eval_pv #endif The right way to do this is to #include ppport.h from Devel::PPPort. -- ams ---(end of

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: I am going to bet dollars to donuts that it is your perl version. Perl 5.00503 is ancient. Try upgrading to at least 5.6. Not much I can do about that - it's builtin as part of FreeBSD 4.x series. Chris isn't the only one who's going to

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Larry Rosenman
On Fri, 2 Jul 2004, Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: I am going to bet dollars to donuts that it is your perl version. Perl 5.00503 is ancient. Try upgrading to at least 5.6. Not much I can do about that - it's builtin as part of FreeBSD 4.x series. Chris isn't

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Christopher Kings-Lynne
In the meantime, does this solve your problem?: #ifndef eval_pv #define eval_pv perl_eval_pv #endif Hmmm, I put it in there and rebuilt and reinstalled and tried again: -bash-2.05b$ createlang -d test plperl ERROR: could not load library /home/chriskl/local/lib/postgresql/plperl.so: dlopen

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Andrew Dunstan
Larry Rosenman said: On Fri, 2 Jul 2004, Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: I am going to bet dollars to donuts that it is your perl version. Perl 5.00503 is ancient. Try upgrading to at least 5.6. Not much I can do about that - it's builtin as part of FreeBSD

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Christopher Kings-Lynne
We seem to have a mixture of old-style and new-style calls which needs to be cleaned up. I would relly appreciate some experienced eyes being cast over this, if there are any around. In the meantime, does this solve your problem?: I went back to clean CVS and I noticed I had these warnings: gcc

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Marc G. Fournier
On Fri, 2 Jul 2004, Larry Rosenman wrote: On Fri, 2 Jul 2004, Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: I am going to bet dollars to donuts that it is your perl version. Perl 5.00503 is ancient. Try upgrading to at least 5.6. Not much I can do about that - it's builtin as

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Andrew Dunstan
Christopher Kings-Lynne said: We seem to have a mixture of old-style and new-style calls which needs to be cleaned up. I would relly appreciate some experienced eyes being cast over this, if there are any around. In the meantime, does this solve your problem?: I went back to clean CVS and I

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Joshua D. Drake
So we have three choices as I see it: 1) revert the change 2) require some minimally recent version of perl 3) fix the issue in place Preferences? Joshua/Andrew -- do you want to take a shot at making this work on perl 5.00503? I personally don't have any desire to make this work on a version of

Re: [HACKERS] compile errors in new PL/Pler

2004-07-02 Thread Andrew Dunstan
Joshua D. Drake said: So we have three choices as I see it: 1) revert the change 2) require some minimally recent version of perl 3) fix the issue in place Preferences? Joshua/Andrew -- do you want to take a shot at making this work on perl 5.00503? I personally don't have any desire

[HACKERS] compile errors in new PL/Pler

2004-07-01 Thread Christopher Kings-Lynne
gmake[3]: Entering directory `/space/1/home/chriskl/pgsql/src/pl/plperl' gcc -O2 -fno-strict-aliasing -g -fpic -DPIC -I. -I/usr/libdata/perl/5.00503/mach/CORE -I../../../src/include -c -o SPI.o SPI.c -MMD SPI.xs: In function `XS__spi_exec_query': SPI.xs:51: `aTHX_' undeclared (first use in

Re: [HACKERS] compile errors in new PL/Pler

2004-07-01 Thread Joshua D. Drake
Christopher Kings-Lynne wrote: gmake[3]: Entering directory `/space/1/home/chriskl/pgsql/src/pl/plperl' gcc -O2 -fno-strict-aliasing -g -fpic -DPIC -I. -I/usr/libdata/perl/5.00503/mach/CORE -I../../../src/include -c -o SPI.o SPI.c -MMD I am going to bet dollars to donuts that it is your perl

Re: [HACKERS] compile errors in new PL/Pler

2004-07-01 Thread Christopher Kings-Lynne
gmake[3]: Entering directory `/space/1/home/chriskl/pgsql/src/pl/plperl' gcc -O2 -fno-strict-aliasing -g -fpic -DPIC -I. -I/usr/libdata/perl/5.00503/mach/CORE -I../../../src/include -c -o SPI.o SPI.c -MMD I am going to bet dollars to donuts that it is your perl version. Perl 5.00503 is

Re: [HACKERS] compile errors in new PL/Pler

2004-07-01 Thread Marc G. Fournier
On Fri, 2 Jul 2004, Christopher Kings-Lynne wrote: gmake[3]: Entering directory `/space/1/home/chriskl/pgsql/src/pl/plperl' gcc -O2 -fno-strict-aliasing -g -fpic -DPIC -I. -I/usr/libdata/perl/5.00503/mach/CORE -I../../../src/include -c -o SPI.o SPI.c -MMD I am going to bet dollars to donuts

Re: [HACKERS] compile errors in new PL/Pler

2004-07-01 Thread Joe Conway
Marc G. Fournier wrote: On Fri, 2 Jul 2004, Christopher Kings-Lynne wrote: I am going to bet dollars to donuts that it is your perl version. Perl 5.00503 is ancient. Try upgrading to at least 5.6. Not much I can do about that - it's builtin as part of FreeBSD 4.x series. And I bet its still the