Re: [HACKERS] external_pid_file not removed on postmaster exit

2012-08-16 Thread Peter Eisentraut
On Fri, 2012-07-27 at 08:09 +0300, Peter Eisentraut wrote: > It seems strange that the external_pid_file is never removed. There is > even a C comment about it: > > /* Should we remove the pid file on postmaster exit? */ > > I think it should be removed with proc_exit hook just like the main > p

Re: [HACKERS] external_pid_file not removed on postmaster exit

2012-07-28 Thread Amit kapila
> From: Tom Lane [t...@sss.pgh.pa.us] > Sent: Saturday, July 28, 2012 9:46 PM Amit kapila writes: >>> I think it should be removed with proc_exit hook just like the main >>> postmaster.pid file. >> external_pid_file is created first time when it is enabled in postgresql.conf >> I think it should

Re: [HACKERS] external_pid_file not removed on postmaster exit

2012-07-28 Thread Tom Lane
Amit kapila writes: >> I think it should be removed with proc_exit hook just like the main >> postmaster.pid file. > external_pid_file is created first time when it is enabled in postgresql.conf > I think it should be removed once the parameter external_pid_file is unset; Unset? If that parame

Re: [HACKERS] external_pid_file not removed on postmaster exit

2012-07-28 Thread Amit kapila
>From: pgsql-hackers-ow...@postgresql.org [pgsql-hackers-ow...@postgresql.org] >on behalf of Peter Eisentraut [pete...@gmx.net] > Sent: Friday, July 27, 2012 10:39 AM > It seems strange that the external_pid_file is never removed. There is > even a C comment about it: > /* Should we remove the

[HACKERS] external_pid_file not removed on postmaster exit

2012-07-26 Thread Peter Eisentraut
It seems strange that the external_pid_file is never removed. There is even a C comment about it: /* Should we remove the pid file on postmaster exit? */ I think it should be removed with proc_exit hook just like the main postmaster.pid file. Does anyone remember why this was not done originall