Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-06-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Jun 1, 2009 at 3:34 PM, Selena Deckelmann sel...@endpoint.com wrote: Suggested revision of Robert's prose: Because genetic query optimization may be triggered, increasing from_collapse_limit should be considered relative to xref

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-06-01 Thread Selena Deckelmann
In the spirit of helping wrap-up 8.4 todo items... Robert Haas wrote: On Mon, May 25, 2009 at 6:15 PM, Tom Lanet...@sss.pgh.pa.us wrote: Now I'm still not exactly happy with GEQO, but it's surely a lot better than it was in the fall of 2000. So on the whole it does seem that the current

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-06-01 Thread Robert Haas
On Mon, Jun 1, 2009 at 3:34 PM, Selena Deckelmann sel...@endpoint.com wrote: In the spirit of helping wrap-up 8.4 todo items... Robert Haas wrote: For 8.4, I'd be happy to just improve the documentation.  I think this sentence could just be deleted from the section on from_collapse_limit: My

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-25 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, May 21, 2009 at 7:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: Josh Berkus j...@agliodbs.com writes: ... trying to remember why I wrote that ... what would happen if FROM_COLLAPSE_LIMIT was *more* than GEQO_THRESHOLD? I think I wrote it, not

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-25 Thread Robert Haas
On Mon, May 25, 2009 at 6:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Now I'm still not exactly happy with GEQO, but it's surely a lot better than it was in the fall of 2000.  So on the whole it does seem that the current relationships between from_collapse_limit, join_collapse_limit, and

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-21 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: Robert, It appears that this statement has been in our documentation since Tom Lane added FROM_COLLAPSE_LIMIT (back then, it was capitalized) on January 25, 2003 (9bf97ff426de9), but I can't find any justification for it anywhere. I think we either need

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-21 Thread Robert Haas
On Thu, May 21, 2009 at 7:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: Josh Berkus j...@agliodbs.com writes: Robert, It appears that this statement has been in our documentation since Tom Lane added FROM_COLLAPSE_LIMIT (back then, it was capitalized) on January 25, 2003 (9bf97ff426de9), but I

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-21 Thread Greg Stark
Having just raised the statistics targets I wonder if we should look at raising these two parameters too. The experience on the lists are that when people run into either of these two limits we recommend raising them and we've never seen anyone come back complaining that their planning time goes

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-21 Thread Robert Haas
On Thu, May 21, 2009 at 8:51 AM, Greg Stark st...@enterprisedb.com wrote: Having just raised the statistics targets I wonder if we should look at raising these two parameters too. The experience on the lists are that when people run into either of these two limits we recommend raising them and

[HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-20 Thread Robert Haas
The docs contain the following sage advice concerning from_collapse_limit: It is usually wise to keep this less than geqo_threshold. I've been thinking through this advice on and off for about 2 years and I still don't understand it. The point of either from_collapse_limit and geqo_threshold is

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-20 Thread Josh Berkus
Robert, It appears that this statement has been in our documentation since Tom Lane added FROM_COLLAPSE_LIMIT (back then, it was capitalized) on January 25, 2003 (9bf97ff426de9), but I can't find any justification for it anywhere. I think we either need to justify this advice, or remove it.

Re: [HACKERS] from_collapse_limit vs. geqo_threshold

2009-05-20 Thread Robert Haas
On Thu, May 21, 2009 at 12:21 AM, Josh Berkus j...@agliodbs.com wrote: It appears that this statement has been in our documentation since Tom Lane added FROM_COLLAPSE_LIMIT (back then, it was capitalized) on January 25, 2003 (9bf97ff426de9), but I can't find any justification for it anywhere.