Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-26 Thread Simon Riggs
On Tue, 2010-08-24 at 18:23 -0700, David Fetter wrote: On Wed, Aug 25, 2010 at 08:11:18AM +0800, Boxuan Zhai wrote: On Wed, Aug 25, 2010 at 4:56 AM, Andres Freund and...@anarazel.de wrote: The concurrency issues are not involved. I don't know much about this part. I think we need more

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-26 Thread Marko Tiikkaja
On 2010-08-25 12:44 PM +0300, Heikki Linnakangas wrote: On 25/08/10 12:41, Andres Freund wrote: But randomly loosing tuples will make much more people unhappy. At a much more problematic point of time (in production). Hmm, how would you lose tuples? I think what Andres means is: T1 starts a

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-25 Thread Heikki Linnakangas
On 24/08/10 23:56, Andres Freund wrote: I have to ask one question: On a short review of the discussion and the patch I didn't find anything about the concurrency issues involved (at least nodeModifyTable.c didnt show any). The SQL spec doesn't require MERGE to be an atomic upsert operation.

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-25 Thread Marko Tiikkaja
On 2010-08-25 9:26 AM +0300, Heikki Linnakangas wrote: Whats the plan to go forward at that subject? I think the patch needs to lock tables exclusively (the pg level, not access exclusive) as long as there is no additional handling... Well, you can always do LOCK TABLE before calling MERGE if

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-25 Thread Andres Freund
On Wed, Aug 25, 2010 at 09:26:51AM +0300, Heikki Linnakangas wrote: On 24/08/10 23:56, Andres Freund wrote: I have to ask one question: On a short review of the discussion and the patch I didn't find anything about the concurrency issues involved (at least nodeModifyTable.c didnt show any).

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-25 Thread Heikki Linnakangas
On 25/08/10 12:41, Andres Freund wrote: But randomly loosing tuples will make much more people unhappy. At a much more problematic point of time (in production). Hmm, how would you lose tuples? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-24 Thread Heikki Linnakangas
On 24/08/10 16:35, Boxuan Zhai wrote: Hi, I finished the MERGE on inheritance tables. Now comes the merge_v201 Oh, great! That means that all the known issues are fixed now, and all that's left is fixing any issues raised in review. I've added this to the September commitfest, but I hope

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-24 Thread Andres Freund
On Tue, Aug 24, 2010 at 11:02:41PM +0300, Heikki Linnakangas wrote: On 24/08/10 16:35, Boxuan Zhai wrote: Hi, I finished the MERGE on inheritance tables. Now comes the merge_v201 Oh, great! That means that all the known issues are fixed now, and all that's left is fixing any issues raised

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-24 Thread Boxuan Zhai
On Wed, Aug 25, 2010 at 4:56 AM, Andres Freund and...@anarazel.de wrote: On Tue, Aug 24, 2010 at 11:02:41PM +0300, Heikki Linnakangas wrote: On 24/08/10 16:35, Boxuan Zhai wrote: Hi, I finished the MERGE on inheritance tables. Now comes the merge_v201 Oh, great! That means that all

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-24 Thread Robert Haas
On Tue, Aug 24, 2010 at 4:56 PM, Andres Freund and...@anarazel.de wrote: Whats the plan to go forward at that subject? I think the patch needs to lock tables exclusively (the pg level, not access exclusive) as long as there is no additional handling... That sounds like it might cause more

Re: [HACKERS] gSoC add MERGE command new patch -- merge_v104

2010-08-24 Thread David Fetter
On Wed, Aug 25, 2010 at 08:11:18AM +0800, Boxuan Zhai wrote: On Wed, Aug 25, 2010 at 4:56 AM, Andres Freund and...@anarazel.de wrote: On Tue, Aug 24, 2010 at 11:02:41PM +0300, Heikki Linnakangas wrote: On 24/08/10 16:35, Boxuan Zhai wrote: Hi, I finished the MERGE on inheritance