Re: [HACKERS] hstore extension version screwup

2013-11-10 Thread Tom Lane
Jim Nasby writes: > On 10/3/13 12:49 PM, Magnus Hagander wrote: >> We could also use git receive hooks, but those would be very hard to >> override when you*do* need to modify the files (which you might >> within a release). > You can have the receive hook ignore the condition on existence of a

Re: [HACKERS] hstore extension version screwup

2013-10-03 Thread Jim Nasby
On 10/3/13 12:49 PM, Magnus Hagander wrote: We could also use git receive hooks, but those would be very hard to override when you*do* need to modify the files (which you might within a release). You can have the receive hook ignore the condition on existence of a file. It's kinda kludgey, bu

Re: [HACKERS] hstore extension version screwup

2013-10-03 Thread Robert Haas
On Wed, Oct 2, 2013 at 1:17 PM, Jim Nasby wrote: > On 9/29/13 9:41 PM, Andrew Dunstan wrote: >> On 09/29/2013 10:38 PM, Peter Eisentraut wrote: >>> >>> On Sun, 2013-09-29 at 22:33 -0400, Andrew Dunstan wrote: Well if these are not meant to be changed then not being able to write the

Re: [HACKERS] hstore extension version screwup

2013-10-03 Thread Magnus Hagander
On Wed, Oct 2, 2013 at 7:17 PM, Jim Nasby wrote: > On 9/29/13 9:41 PM, Andrew Dunstan wrote: >> >> >> On 09/29/2013 10:38 PM, Peter Eisentraut wrote: >>> >>> On Sun, 2013-09-29 at 22:33 -0400, Andrew Dunstan wrote: Well if these are not meant to be changed then not being able to write >>

Re: [HACKERS] hstore extension version screwup

2013-10-02 Thread Jim Nasby
On 9/29/13 9:41 PM, Andrew Dunstan wrote: On 09/29/2013 10:38 PM, Peter Eisentraut wrote: On Sun, 2013-09-29 at 22:33 -0400, Andrew Dunstan wrote: Well if these are not meant to be changed then not being able to write them in your git repo might be a clue to that. Git doesn't support setting

Re: [HACKERS] hstore extension version screwup

2013-09-29 Thread Andrew Dunstan
On 09/29/2013 10:38 PM, Peter Eisentraut wrote: On Sun, 2013-09-29 at 22:33 -0400, Andrew Dunstan wrote: Well if these are not meant to be changed then not being able to write them in your git repo might be a clue to that. Git doesn't support setting file permissions other than the executable

Re: [HACKERS] hstore extension version screwup

2013-09-29 Thread Peter Eisentraut
On Sun, 2013-09-29 at 22:33 -0400, Andrew Dunstan wrote: > Well if these are not meant to be changed then not being able to write > them in your git repo might be a clue to that. Git doesn't support setting file permissions other than the executable bit, so this is a nonstarter. -- Sent via

Re: [HACKERS] hstore extension version screwup

2013-09-29 Thread Andrew Dunstan
On 09/29/2013 09:58 PM, Peter Eisentraut wrote: On Fri, 2013-09-27 at 13:23 -0400, Andrew Dunstan wrote: This was lazy and there's no real excuse, although I will note that it was a mistake far too easy to make. Perhaps as a warning indicator we should remove write permissions from these files.

Re: [HACKERS] hstore extension version screwup

2013-09-29 Thread Peter Eisentraut
On Fri, 2013-09-27 at 13:23 -0400, Andrew Dunstan wrote: > This was lazy and there's no real excuse, although I will note that it > was a mistake far too easy to make. Perhaps as a warning indicator we > should remove write permissions from these files. What do you mean by that? > See attached

[HACKERS] hstore extension version screwup

2013-09-27 Thread Andrew Dunstan
When adding json support to hstore, I made a major blunder and added the new functionality to the existing sql script instead of bumping the version, renaming the script and adding an update script. This was lazy and there's no real excuse, although I will note that it was a mistake far too