Re: [HACKERS] pg_controldata output alignment regression

2015-08-25 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/25/2015 12:41 PM, Alvaro Herrera wrote: > Joe Conway wrote: >> On 08/25/2015 11:28 AM, Alvaro Herrera wrote: >>> Joe Conway wrote: >>> Does anyone out there object to a non-backward compatible change to pg_controldata output? >>> >>>

Re: [HACKERS] pg_controldata output alignment regression

2015-08-25 Thread Alvaro Herrera
Joe Conway wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 I should have gotten my key signed when I had the chance :-( > On 08/25/2015 11:28 AM, Alvaro Herrera wrote: > > Joe Conway wrote: > > > >> Does anyone out there object to a non-backward compatible change > >> to pg_controldata

Re: [HACKERS] pg_controldata output alignment regression

2015-08-25 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/25/2015 11:28 AM, Alvaro Herrera wrote: > Joe Conway wrote: > >> Does anyone out there object to a non-backward compatible change >> to pg_controldata output? > > I don't (and thanks for taking care of it), but as I recall, > pg_upgrade reads a

Re: [HACKERS] pg_controldata output alignment regression

2015-08-25 Thread Alvaro Herrera
Joe Conway wrote: > Does anyone out there object to a non-backward compatible change to > pg_controldata output? I don't (and thanks for taking care of it), but as I recall, pg_upgrade reads and interprets pg_controldata output so it may need adjustment too. -- Álvaro Herrerahtt

Re: [HACKERS] pg_controldata output alignment regression

2015-08-25 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/25/2015 10:32 AM, Joe Conway wrote: > On 08/25/2015 10:28 AM, Tom Lane wrote: >> I was suggesting getting rid of "Current" in *all* the entries. >> What value does it add? > > I agree, it adds no value, and is a simple solution. > > Does anyon

Re: [HACKERS] pg_controldata output alignment regression

2015-08-25 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/25/2015 10:28 AM, Tom Lane wrote: > Joe Conway writes: >> On 08/24/2015 07:41 PM, Tom Lane wrote: >>> Seems to me we could s/Current //g, or s/ setting//g, or both, >>> and get rid of the problem without adding more whitespace. > >> I'd agree,

Re: [HACKERS] pg_controldata output alignment regression

2015-08-25 Thread Tom Lane
Joe Conway writes: > On 08/24/2015 07:41 PM, Tom Lane wrote: >> Seems to me we could s/Current //g, or s/ setting//g, or both, and >> get rid of the problem without adding more whitespace. > I'd agree, except I think not everyone might be happy with that. The > surrounding lines look like: I was

Re: [HACKERS] pg_controldata output alignment regression

2015-08-25 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/24/2015 07:41 PM, Tom Lane wrote: > Joe Conway writes: >> Do we care that as of 9.5 pg_controldata output is not 100% >> aligned anymore? The culprit is: Current track_commit_timestamp >> setting: off Its value is shifted 2 characters to the rig

Re: [HACKERS] pg_controldata output alignment regression

2015-08-24 Thread Tom Lane
Joe Conway writes: > Do we care that as of 9.5 pg_controldata output is not 100% aligned > anymore? The culprit is: > Current track_commit_timestamp setting: off > Its value is shifted 2 characters to the right with respect to all the > others. I think it ought to be fixed but thought I'd get op

[HACKERS] pg_controldata output alignment regression

2015-08-24 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Do we care that as of 9.5 pg_controldata output is not 100% aligned anymore? The culprit is: Current track_commit_timestamp setting: off Its value is shifted 2 characters to the right with respect to all the others. I think it ought to be fixed but