Re: [HACKERS] pg_dump vs data-only dumps vs --disable-triggers

2008-07-25 Thread Simon Riggs
On Thu, 2008-07-24 at 19:11 -0400, Tom Lane wrote: > There's some fairly squirrely logic in pg_dump/pg_restore that tries to > detect whether it's doing a data-only operation, ie, no schema > information is to be dumped or restored. The reason it wants to > know this is to decide whether to enabl

Re: [HACKERS] pg_dump vs data-only dumps vs --disable-triggers

2008-07-24 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: > Simon's patch to split up --schema-only into two switches has broken > this logic, but I'm inclined to just rip it out rather than trying > to fix it. If the user says --disable-triggers, he should get > trigger disable commands around the data part of the d

Re: [HACKERS] pg_dump vs data-only dumps vs --disable-triggers

2008-07-24 Thread Andrew Dunstan
Tom Lane wrote: If the user says --disable-triggers, he should get trigger disable commands around the data part of the dump, no matter what he said or didn't say about schema dumping. Right. They seem like orthogonal issues. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-

[HACKERS] pg_dump vs data-only dumps vs --disable-triggers

2008-07-24 Thread Tom Lane
There's some fairly squirrely logic in pg_dump/pg_restore that tries to detect whether it's doing a data-only operation, ie, no schema information is to be dumped or restored. The reason it wants to know this is to decide whether to enable the --disable-triggers code. However, since --disable-tri