Re: [HACKERS] pg_prewarm really needs some CHECK_FOR_INTERRUPTS

2014-11-12 Thread Andres Freund
On 2014-11-11 12:17:11 +0100, Andres Freund wrote: > pg_prewarm() currently can't be cannot be interrupted - which seems odd > given that it's intended to read large amounts of data from disk. A > rather slow process. > > Unless somebody protests I'm going to add a check to the top of each of > th

Re: [HACKERS] pg_prewarm really needs some CHECK_FOR_INTERRUPTS

2014-11-11 Thread Robert Haas
On Tue, Nov 11, 2014 at 6:17 AM, Andres Freund wrote: > pg_prewarm() currently can't be cannot be interrupted - which seems odd > given that it's intended to read large amounts of data from disk. A > rather slow process. Oops. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterpr

Re: [HACKERS] pg_prewarm really needs some CHECK_FOR_INTERRUPTS

2014-11-11 Thread Michael Paquier
On Tue, Nov 11, 2014 at 8:17 PM, Andres Freund wrote: > pg_prewarm() currently can't be cannot be interrupted - which seems odd > given that it's intended to read large amounts of data from disk. A > rather slow process. > > Unless somebody protests I'm going to add a check to the top of each of >

[HACKERS] pg_prewarm really needs some CHECK_FOR_INTERRUPTS

2014-11-11 Thread Andres Freund
Hi, pg_prewarm() currently can't be cannot be interrupted - which seems odd given that it's intended to read large amounts of data from disk. A rather slow process. Unless somebody protests I'm going to add a check to the top of each of the three loops. Greetings, Andres Freund -- Andres Fre